Skip to content

Fix update-Mgmt-CI.ps1 to unblock release planner #50137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArthurMa1978 opened this issue May 19, 2025 · 4 comments
Closed

Fix update-Mgmt-CI.ps1 to unblock release planner #50137

ArthurMa1978 opened this issue May 19, 2025 · 4 comments
Assignees
Labels
Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)

Comments

@ArthurMa1978
Copy link
Member

Currently, the update-Mgmt-CI.ps1 script updates the CI file incorrectly for Storage and needs to be fixed.

@ArthurMa1978 ArthurMa1978 added the Mgmt This issue is related to a management-plane library. label May 19, 2025
Copy link

Hi @ArthurMa1978, I'm an AI Support assistant here to help with your issue. While the Azure SDK team reviews your request, I wanted to provide some possible tips and documentation that might help you in the meantime.

  • Ensure that the new package path and resource provider casing (e.g., "Azure.ResourceManager.Rp" or "Microsoft.Compute") are used correctly in the script, as noted in the documentation.
  • Verify that the script properly updates the paths in the ci.mgmt.yml file every time a new package is changed.
  • Use the same approach as when running the command with --includeCI true to ensure consistency.
  • Double-check any custom modifications for the Storage update to confirm that directory and provider name formats match the expected schema, which could be causing the CI path issue.

The Azure SDK team will respond to your issue shortly. I hope these suggestions are helpful in the meantime. If this comment helped you, please give it a 👍. If the suggestion was not helpful or incorrect, please give it a 👎. Your feedback helps us improve!

@github-actions github-actions bot added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files) labels May 19, 2025
@haiyuazhang
Copy link
Contributor

haiyuazhang commented May 20, 2025

The recent change to the storage/ci.yml is the root cause. The script update-Mgmt-CI.ps1 only works with a specific input format of ci.yml. This simple modification to the storage/ci.yml can resolve the issue.

The expected format should be like the following (as in the appconfiguration/ci.ym, single include for service directory path followed by one or more exclude paths)

Image

with the current storage/ci.yml, the AutoPR generated from other resource, as shown in here, will incorrectly add additional lines into storage/ci.yml

Image

@jsquire
Copy link
Member

jsquire commented May 21, 2025

@haiyuazhang, @ArthurMa1978: This is an issue in your script that needs to be fixed. You should not assume any specific form of ci.yml, as packages will extend to meet their own unique needs. Also, that automated PR is straight-up wrong. It should NEVER modify configuration outside of the /sdk area that it is running.

@haiyuazhang
Copy link
Contributor

Ray confirmed update-Mgmt-CI.ps1 can be and will be deprecated. This is the issue he created to track the deprecation work. With that, we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants