From a3eb9da782cbb4e6d828768f6926a141d55a91b7 Mon Sep 17 00:00:00 2001 From: Daniel Jurek Date: Thu, 1 May 2025 21:38:01 -0700 Subject: [PATCH 1/2] cspell: Remove node version requirement, node is already on the agent --- eng/common/pipelines/templates/steps/check-spelling.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/eng/common/pipelines/templates/steps/check-spelling.yml b/eng/common/pipelines/templates/steps/check-spelling.yml index a25fd9444118..f02c7596794a 100644 --- a/eng/common/pipelines/templates/steps/check-spelling.yml +++ b/eng/common/pipelines/templates/steps/check-spelling.yml @@ -15,12 +15,6 @@ parameters: steps: - ${{ if eq(variables['Build.Reason'], 'PullRequest') }}: - - task: NodeTool@0 - condition: and(succeededOrFailed(), ne(variables['Skip.SpellCheck'],'true')) - inputs: - versionSpec: 18.x - displayName: Use Node.js 18.x - - task: PowerShell@2 displayName: Check spelling (cspell) condition: and(succeededOrFailed(), ne(variables['Skip.SpellCheck'],'true')) From 095a2733fa57c3a95186896c1ef58a8b227dfcac Mon Sep 17 00:00:00 2001 From: Daniel Jurek Date: Tue, 6 May 2025 15:21:48 -0700 Subject: [PATCH 2/2] Succeeded --- eng/common/pipelines/templates/steps/check-spelling.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/pipelines/templates/steps/check-spelling.yml b/eng/common/pipelines/templates/steps/check-spelling.yml index f02c7596794a..8d7a716cbdfc 100644 --- a/eng/common/pipelines/templates/steps/check-spelling.yml +++ b/eng/common/pipelines/templates/steps/check-spelling.yml @@ -17,7 +17,7 @@ steps: - ${{ if eq(variables['Build.Reason'], 'PullRequest') }}: - task: PowerShell@2 displayName: Check spelling (cspell) - condition: and(succeededOrFailed(), ne(variables['Skip.SpellCheck'],'true')) + condition: and(succeeded(), ne(variables['Skip.SpellCheck'],'true')) continueOnError: ${{ parameters.ContinueOnError }} inputs: targetType: filePath