Skip to content

[FEATURE REQ] Support .tsp-only PRs in incremental TypeSpec detection for ARM Auto SignOff #40384

@FumingZhang

Description

@FumingZhang

API Spec link

N/A

API Spec version

N/A

Please describe the feature.

Hi @AkhilaIlla , @mikeharder , @raosuhas, could the incremental TypeSpec detection be extended to support PRs that only modify .tsp files?

Currently, arm-incremental-typespec.js maps changed files to spec directories using only swagger(), example() and readme() filters, so .tsp-only PRs always result in an empty changedSpecDirs and return false. This means TypeSpec-only changes to an existing TypeSpec RP can't receive ARMAutoSignedOff-IncrementalTSP and must wait for manual ARM review.

Adding .tsp files (via the existing typespec() filter) to the changedSpecDirs computation would address this, and the existing base-branch check (verifying TypeSpec-generated swagger already exists) would still guard against false positives.

This would significantly reduce review wait times for teams working in TypeSpec. We recently migrated from raw swagger to TypeSpec, and we're working on refactoring the tsp files to resolve some FIXMEs left by the auto conversion tool. These updates will not alter the generated swagger, ensuring we don't introduce any unintended changes. For instance, this is PR #40221, along with the current outcome from 'Checking for incremental TypeSpec changes'.

2026-02-09T02:57:36.268Z simple-git [GitExecutor] [SPAWN] git [ 'diff', '--name-status', 'HEAD^', 'HEAD' ]
Could not map changed files to any spec directories
Incremental TypeSpec result: false

Thanks for considering!

cc @matthchr , @palma21

Metadata

Metadata

Assignees

Labels

feature-requestThis issue requires a new behavior in the product in order be resolved.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions