fix small issues

Author: Pan-Qi

.azure-pipelines/PipelineSteps/BatchGeneration/batch-generate-modules.ps1

@@ -87,16 +87,25 @@ foreach ($moduleName in $sortedModuleNames) {
     if ($diff) {
         Write-Host "Changes detected in $moduleName, adding change log"
         $moduleResult.Changed = "Yes"
+
+        $date = Get-Date -Format "yy-MM-dd"
+        $newChangeLogEntry = "* Autorest version: $AutorestVersion - $date"
+        
+        $updatedContent = @()
         $changeLogPath = Join-Path $RepoRoot "src" $moduleName $moduleName "AutorestUpgradeLog.md"
+
         if (-not (Test-Path $changeLogPath)) {
             New-Item -Path $changeLogPath -ItemType File -Force | Out-Null
-            Add-Content -Path $changeLogPath -Value "## Autorest upgrade log"
+            $updatedContent += "## Autorest upgrade log"
+            $updatedContent += $newChangeLogEntry
+        } else{
+            $changeLogContent = Get-Content -Path $changeLogPath
+            $updatedContent += $changeLogContent[0]
+            $updatedContent += $newChangeLogEntry
+            $updatedContent += $changeLogContent[1..($changeLogContent.Count - 1)]
         }
-        $changeLogContent = Get-Content -Path $changeLogPath
-        $date = Get-Date -Format "dd/MM/yy"
-        $newChangeLogEntry = "* Autorest version: $AutorestVersion - $date"
-        $changeLogContent.Insert(1, $newChangeLogEntry)
-        Set-Content $changeLogPath -Value $changeLogContent
+        Set-Content $changeLogPath -Value $updatedContent
+
         $moduleResult.Changed = "Yes, Autorest Change Log Updated"
         Write-Host "New change log entry added to $changeLogPath"
     }

.azure-pipelines/PipelineSteps/BatchGeneration/notify-failed-job.ps1

@@ -5,13 +5,6 @@ param (
 $utilFilePath = Join-Path $RepoRoot '.azure-pipelines' 'PipelineSteps' 'BatchGeneration' 'util.psm1'
 Import-Module $utilFilePath -Force
 
-$batchGenSubscribers = @(
-    "bernardpan@microsoft.com",
-    "xidi@microsoft.com",
-    "yabhu@microsoft.com"
-)
-$receivers = $batchGenSubscribers -join ","
-
 $pipelineName = $env:BUILD_DEFINITIONNAME
 $pipelineUrl = "$($env:SYSTEM_TEAMFOUNDATIONCOLLECTIONURI)$($env:SYSTEM_TEAMPROJECT)/_build?definitionId=$($env:SYSTEM_DEFINITIONID)"
 $runUrl = "$($env:SYSTEM_TEAMFOUNDATIONCOLLECTIONURI)$($env:SYSTEM_TEAMPROJECT)/_build/results?buildId=$($env:BUILD_BUILDID)"
@@ -23,6 +16,6 @@ $notificationContent = $notificationTemplate -replace "{{ pipelineName }}", $pip
                                             -replace "{{ runUrl }}", $runUrl
 
 Send-Teams `
-    -to $receivers `
+    -to $env:FailedJobNotificationReceivers `
     -title "Batch Generation Job Failed" `
     -content $notificationContent

.azure-pipelines/batch-generation.yml

@@ -2,7 +2,7 @@ parameters:
 - name: AutorestVersion
   displayName: 'Version of Autorest that trigger batch generation'
   type: string
-  default: 'Default version'
+  default: '4.x.x'
 
 variables:
   IntermediateStepTimeoutInMinutes: 30
@@ -52,7 +52,7 @@ stages:
             $token = "$(GitHubToken)"
 
             $createBranchPath = Join-Path "$(Build.SourcesDirectory)" '.azure-pipelines' 'PipelineSteps' 'BatchGeneration' 'create-branch.ps1'
-            & $createBranchPath -Owner 'Azure' -Repo 'azure-powershell' -BaseBranch 'main' -NewBranch $generationBranch -Token $token
+            & $createBranchPath -Owner 'Azure' -Repo 'azure-powershell' -BaseBranch "$(GenerationBaseBranch)" -NewBranch $generationBranch -Token $token
             Write-Host "##vso[task.setvariable variable=GenerationBranch;isOutput=true]$generationBranch"
 
       - task: PowerShell@2
@@ -490,3 +490,4 @@ stages:
                 & $notificationScriptPath -RepoRoot "$(Build.SourcesDirectory)"
             env:
               TEAMS_URL: $(TEAMS_URL)
+              FailedJobNotificationReceivers: $(FailedJobNotificationReceivers)