Skip to content

Optimize FeatureFlags.IsEnabled #10883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kshyju opened this issue Feb 26, 2025 · 0 comments · Fixed by #11076
Closed

Optimize FeatureFlags.IsEnabled #10883

kshyju opened this issue Feb 26, 2025 · 0 comments · Fixed by #11076
Assignees
@kshyju
Labels
perf

Comments

@kshyju
Copy link
Member

kshyju commented Feb 26, 2025

The FeatureFlags.IsEnabled method currently uses string.Split, which results in a string array allocation. Instead, we can optimize this by using ReadOnlySpan<char> to check if the requested feature name is present, avoiding the extra allocation.

azure-functions-host/src/WebJobs.Script/Config/FeatureFlags.cs

Lines 22 to 23 in 5a87303

string[] flags = featureFlags.Split(',');
return flags.Contains(name, StringComparer.OrdinalIgnoreCase);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kshyju kshyju

Labels
perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce allocations in FeatureFlags.IsEnabled Azure/azure-functions-host
1 participant
@kshyju