NullPointerException when calling readDatabase, need retry logic

[zhang-hua]

[�[33mwarn�[0m] c.m.a.d.DocumentClient - Failed to retrieve database account information. java.net.UnknownHostException: xxxxxxxxx.documents.azure.com: Try again
...
Error while getting DocumentDb database
java.lang.NullPointerException: null
	at com.microsoft.azure.documentdb.internal.BaseDatabaseAccountConfigurationProvider.getMaxReplicaSetSize(BaseDatabaseAccountConfigurationProvider.javdockersdockea:33)
	at com.microsoft.azure.documentdb.internal.directconnectivity.ConsistencyReader.read(ConsistencyReader.java:44)
	at com.microsoft.azure.documentdb.internal.directconnectivity.ReplicatedResourceClient.invoke(ReplicatedResourceClient.java:59)
	at com.microsoft.azure.documentdb.internal.directconnectivity.ServerStoreModel$1.apply(ServerStoreModel.java:84)
	at com.microsoft.azure.documentdb.internal.RetryUtility.executeStoreClientRequest(RetryUtility.java:113)
	at com.microsoft.azure.documentdb.internal.directconnectivity.ServerStoreModel.processMessage(ServerStoreModel.java:89)
	at com.microsoft.azure.documentdb.DocumentClient$8.apply(DocumentClient.java:2980)
	at com.microsoft.azure.documentdb.internal.RetryUtility.executeDocumentClientRequest(RetryUtility.java:58)
	at com.microsoft.azure.documentdb.DocumentClient.doRead(DocumentClient.java:2986)
	at com.microsoft.azure.documentdb.DocumentClient.readDatabase(DocumentClient.java:490)

[zhang-hua]

This issue can be fixed by adding some retry logic in getDatabaseAccountFromEndpoint() method of com/microsoft/azure/documentdb/DocumentClient.java :

DatabaseAccount getDatabaseAccountFromEndpoint(URI endpoint) throws DocumentClientException {
        DocumentServiceRequest request = DocumentServiceRequest.create(OperationType.Read, ResourceType.DatabaseAccount, "", null);
        this.putMoreContentIntoDocumentServiceRequest(request, HttpConstants.HttpMethods.GET);

        DocumentServiceResponse response = null;
        int retryCount = 32;
        while (--retryCount > 0) {
            try {
                request.setEndpointOverride(endpoint);
                response = this.gatewayProxy.doRead(request);
                break;
            } catch (IllegalStateException e) {
                // Ignore all errors. Discover is an optimization.
                String message = "Failed to retrieve database account information. %s";
                Throwable cause = e.getCause();
                if (cause != null) {
                    message = String.format(message, cause.toString());
                } else {
                    message = String.format(message, e.toString());
                }

                logger.warn(message);

                // catch UnknownHostException and retry
                if (cause instanceof UnknownHostException) {
                    try {
                        Thread.sleep(5000);
                    } catch (InterruptedException e1) {
                        e1.printStackTrace();
                        break;
                    }
                } else {
                    break;
                }
            }
        }

        if (response != null) {
            return response.getResource(DatabaseAccount.class);
        } else {
            return null;
        }
    }

[moderakh]

@srinathnarayanan can you please take a look at this one?

[srinathnarayanan]

Hi @zhang-hua I couldn't repro this issue. Are you still running into it? Is this is directMode or gateway?

[zhang-hua]

@srinathnarayanan , This only happened just after the DocumentDB account is deployed in a few minutes. I also tried to switch between direct and gateway mode but it doesn't work. Before NullPointerException thrown, there is an UnknownHostException which indicated the route to DocumentDB service is not reachable for a while at the beginning. The DocumentDB client of Java SDK doesn't have any retrying logic underline and fail very quickly with NullPointerException caused by this UnknownHostException. It happens very often in our IOT PCS2 solution because of we implemented a micro-service to initialize the DocumentDB database once booted after the account is successfully deployed by ARM. Please feel free to ping me if you need more details.

[vkumarsharma]

This is issue is hurting us for a long time now on our production server.
This issue is very frequent on our production server. Even when we put the DNS address of the cosmosdb end point in out etc/hosts in our VM.

All our production environment is on Azure and we have logged multiple tickets with microsoft but they haven't been able to help. And then I find this thread. Please help with this. I will be able to do a screenshare if needed.

Can it be related to cosmosdb throttling the requests when the load is high. Because this issue comes to us randomly and corrects itself after few hours.

[srinathnarayanan]

@zhang-hua @vkumarsharma which OS are you using when you run into this issue?

[zhang-hua]

@srinathnarayanan, this issue occurs in a Linux container.

[vkumarsharma]

For us it is Ubuntu VM with tomcat8, no container

[zhang-hua]

hey, @srinathnarayanan, do you need any more info for this issue or have any update on this? Thanks!

[srinathnarayanan]

Hi @zhang-hua we are actively working on this and will add the retries to our next release. Thanks!

[zhang-hua]

@srinathnarayanan , very appreciated! :-)

[kirankumarkolli]

@zhang-hua just to confirm after ARM confirmed that cosmos account is created is when you getting this error on that account right? Could you please share the time when this happened, account. Ideally post account creation this failure should not happen.