Skip to content

CNS Possibly Not Handling Error Correctly and Possibly Not Releasing IP Address #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MikeZappa87 opened this issue Apr 3, 2025 · 2 comments · May be fixed by #3672
Open

CNS Possibly Not Handling Error Correctly and Possibly Not Releasing IP Address #3557

MikeZappa87 opened this issue Apr 3, 2025 · 2 comments · May be fixed by #3672
Assignees
@rbtr @camrynl @Copilot
Labels
bug cni Related to CNI. cns Related to CNS.

Comments

@MikeZappa87
Copy link
Contributor

MikeZappa87 commented Apr 3, 2025 •
edited
Loading

I have not observed this however while reading the code, I noticed this as a possible condition that may not release the ip address.

azure-container-networking/cns/fsnotify/fsnotify.go

Line 60 in a2a2ab8

file, err := os.Open(filepath)

If os.Open(..) returns an error, we log however continue. io.ReadAll(...) returns an invalid argument error and continues (but logs error). The .Close function handles the nil condition and continues.

podInterfaceID := string(data) is just an empty string and assuming what ever was supposed to happen on line

azure-container-networking/cns/fsnotify/fsnotify.go

Line 73 in a2a2ab8

if err := w.releaseIP(ctx, podInterfaceID, containerID); err != nil {
is not happening?

Note: I didn't do a full analysis however the function looks suspect.
@MikeZappa87 MikeZappa87 changed the title CNS Possibly Not Handling Error Correctly and Not Releasing IP Address CNS Possibly Not Handling Error Correctly and Possibly Not Releasing IP Address Apr 3, 2025
@rbtr rbtr assigned rbtr and camrynl Apr 4, 2025
@rbtr rbtr added cns Related to CNS. cni Related to CNI. labels Apr 4, 2025
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Apr 19, 2025
@rbtr rbtr removed the stale Stale due to inactivity. label Apr 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025

This issue is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label May 6, 2025
@MikeZappa87 MikeZappa87 removed the stale Stale due to inactivity. label May 6, 2025
@Copilot Copilot AI linked a pull request May 19, 2025 that will close this issue
Draft
@rbtr rbtr added the bug label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbtr rbtr

@camrynl camrynl

Copilot code review Copilot

Labels
bug cni Related to CNI. cns Related to CNS.
Projects
None yet
Milestone
No milestone
3 participants
@rbtr @camrynl @MikeZappa87