Skip to content

Commit 67d2c5a

Browse files
authored
chore: address todo items in cilium e2e templates (#3675)
* chore: address todo remove repeated validate pods check * chore: address todo delete echo-external-node deployment and deleting connectivity test resources * delete deployment
1 parent 6fc92ad commit 67d2c5a

File tree

4 files changed

+0
-25
lines changed

4 files changed

+0
-25
lines changed

.pipelines/singletenancy/cilium-dualstack-overlay/cilium-dualstackoverlay-e2e-step-template.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,6 @@ steps:
133133
- script: |
134134
echo "validate pod IP assignment and check systemd-networkd restart"
135135
kubectl get pod -owide -A
136-
# Deleting echo-external-node deployment until cilium version matches TODO. https://github.com/cilium/cilium-cli/issues/67 is addressing the change.
137-
# Saves 17 minutes
138-
kubectl delete deploy -n $(ciliumNamespace) echo-external-node
139136
cd test/integration/load
140137
CNI_TYPE=cilium_dualstack go test -timeout 30m -tags load -run ^TestValidateState$
141138
echo "delete cilium connectivity test resources and re-validate state"

.pipelines/singletenancy/cilium-overlay-withhubble/cilium-overlay-e2e-step-template.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,6 @@ steps:
148148
kubectl get ciliumidentity | grep cilium-test
149149
fi
150150
make test-validate-state
151-
echo "delete cilium connectivity test resources and re-validate state" # TODO Delete this and the next 4 lines if connectivity no longer has bug
152-
kubectl delete ns $(ciliumNamespace)
153-
kubectl get pod -owide -A
154-
make test-validate-state
155151
name: "validatePods"
156152
displayName: "Validate Pods"
157153

.pipelines/singletenancy/cilium-overlay/cilium-overlay-e2e-step-template.yaml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -214,20 +214,6 @@ steps:
214214
name: "CiliumIdentities"
215215
displayName: "Verify Cilium Identities Deletion"
216216
217-
- script: | # TODO REMOVE THIS STEP, make test-load covers this
218-
set -e
219-
echo "validate pod IP assignment before CNS restart"
220-
kubectl get pod -owide -A
221-
make test-validate-state
222-
echo "restart CNS"
223-
kubectl rollout restart ds azure-cns -n kube-system
224-
kubectl rollout status ds azure-cns -n kube-system
225-
kubectl get pod -owide -A
226-
echo "validate pods after CNS restart"
227-
make test-validate-state
228-
name: "restartCNS"
229-
displayName: "Restart CNS and validate pods"
230-
231217
- script: |
232218
echo "Run wireserver and metadata connectivity Tests"
233219
bash test/network/wireserver_metadata_test.sh

.pipelines/templates/cilium-tests.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,6 @@ steps:
6262
echo "validate pod IP assignment and check systemd-networkd restart"
6363
kubectl get pod -owide -A
6464
make test-validate-state
65-
echo "delete cilium connectivity test resources and re-validate state" # TODO Delete this and the next 4 lines if connectivity no longer has bug
66-
kubectl delete ns $(ciliumNamespace)
67-
kubectl get pod -owide -A
68-
make test-validate-state
6965
name: "validatePods"
7066
displayName: "Validate Pods"
7167

0 commit comments

Comments
 (0)