Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Innersource CI Issue from Discussions] Enable azure tags in deployment validation scripts #4546

Open
eriqua opened this issue May 20, 2024 Discussed in #3489 · 2 comments

Comments

@eriqua
Copy link
Contributor

eriqua commented May 20, 2024

Discussed in #3489

Originally posted by ThojoUno August 2, 2023
We have a very restricted lab/test environment that REQUIRES Azure tags on all resource groups. Because of this, we can't perform deployment validation with the current branch. It would be quite easy to implement but requires updating every main.test.bicep template.
Steps to implement:

  1. update ./settings.yml, add tags environment variable

Update Deployment validation section
location: 'centralus'
tags: '@{"Environment"="Lab";"Expiry Date"="12/31/2023";"Business Unit"="Cloud";"Owner"="Joe Thompson"}'

  1. update settings.yml under .github/actions/templates/validateModuleDeployment

Replace AdditionalParameters = @{} with AdditionalParameters = @{ tags=${{ env.tags }} }
There are 2 instances in this file to replace.

  1. update all .test/scenario/main.test.bicep files to add tags parameter for resource group resource..

Add
@description('Optional. Some environments require tagging.')
param tags object = {}

Update
// General resources
// =================
resource resourceGroup 'Microsoft.Resources/resourceGroups@2021-04-01' = {
name: resourceGroupName
location: location
tags: tags //<=== add tag parameter
}

@eriqua
Copy link
Contributor Author

eriqua commented May 20, 2024

@AlexanderSehr off the top of my head I see this option as a possible feature for the innersource CI, as strictly related to users' CI environment.

@AlexanderSehr
Copy link
Contributor

very restricted lab/test environment that REQUIRES Azure tags on all resource groups. Because of this, we can't perform deployment validation with the current branch. It would be quite easy to implement but requires updating every main.test.bicep template. Steps to implement:

  1. update ./settings.yml, add tags environment variable

Update Deployment validation section location: 'centralus' tags: '@{"Environment"="Lab";"Expiry Date"="12/31/2023";"Business Unit"="Cloud";"Owner"="Joe Thompson"}'

  1. update settings.yml under .github/actions/templates/valida

Agreed. Will tag it with the corresponding milestone. Thanks

@AlexanderSehr AlexanderSehr added this to the Azure Verfified Modules (AVM) - CI Issues milestone May 21, 2024
@AlexanderSehr AlexanderSehr removed this from the Azure Verfified Modules (AVM) - CI Issues milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants