-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Dockerized PyRIT with Jupyter Notebook Support #767
Comments
@ErdemOzgen we're definitely interested. There's an existing Dockerfile that we use to run the GCG attack in Azure (you can find it by searching for a Dockerfile in the repo). Very similar to what you're describing. I'd love to see if we can stick with a single Dockerfile for all cases, and I'm not opinionated on which one. I just struggled a lot with making the container actually use torch properly so I ended up with one that Azure provides. The existing one has some issues, too. It just installs the latest version of |
I'll start working on this issue immediately and will focus on:
Regarding the PyTorch integration challenges you mentioned, I've worked with similar configurations before and will pay special attention to ensuring proper GPU utilization and PyTorch compatibility across different environments. I'll create a development branch with my proposed changes and provide regular updates on my progress. Feel free to assign this issue to me, and I'll submit an initial pull request with a prototype solution within the following weeks for your review. Would you prefer I start from the existing Dockerfile and modify it, or would you be open to a fresh implementation that incorporates the best elements of the current solution? |
Amazing! I have no opinions on the base image besides
So by all means, feel free to explore options. |
I've created an initial proof of concept implementation before submitting a formal PR. The changes can be viewed here: I'd appreciate your feedback on this approach before proceeding with a full PR. Let me know if you have any questions or suggestions for improvements. Thanks! |
Thanks @ErdemOzgen ! I see you went with a Microsoft-provided image after all 🙂 @bashirpartovi @rlundeen2 may have thoughts. To me, this looks ready for a PR so that we can leave detailed comments. The high-level approach makes sense to me. You might want to install pyrit with the "all" extra, i.e. I would love to consolidate and use this instead of the GCG Dockerfile that we have elsewhere in the repo, too, but that can also be a follow-up item. |
@romanlutz The pull request has been opened and is now available for review at #784 |
Is your feature request related to a problem? Please describe.
Users need to manage dependencies, compatibility issues, and configuration steps individually, often leading to inconsistent environments and installation failures across different systems. This creates barriers to entry for new users and unnecessary friction for experienced users who want to quickly deploy Pyrit in different environments.
Describe the solution you'd like
I propose adding a Dockerfile to the Pyrit repository that includes:
This solution would make Pyrit more accessible and portable by allowing users to run it in a consistent, isolated environment without needing to modify their host system or create specialized conda environments. Users would be able to get started with a simple docker pull and docker run command sequence.
The Dockerfile should:
Possible base image : https://quay.io/repository/jupyter/pytorch-notebook?tab=tags&tag=latest
I am willing to contribute to this feature's development if the maintainers are receptive to the idea.
The text was updated successfully, but these errors were encountered: