feat: consolidate network upgrade infrastructure with forge scripts #18622
+2,147
−325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Design documents for consolidating L1 contract deployment around Forge scripts, replacing the current TypeScript deploy_l1_contracts.ts infrastructure. Key decisions: - Forge scripts will live in l1-contracts/script/deploy/ - TypeScript becomes thin wrapper calling forge script - E2E tests maintained via backwards-compatible API - Phased rollout with fallback to existing implementation Documents include: - NETWORK_UPGRADE_INFRASTRUCTURE_CONSOLIDATION.md: Overall design - NETWORK_UPGRADE_IMPLEMENTATION_ROADMAP.md: Detailed phases 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…etwork-upgrade-infrastructure
Implements Forge deployment scripts following the ignition-monorepo pattern: - Add DeployL1Contracts.s.sol for full L1 deployment via Forge - Add DeployRollupForUpgrade.s.sol for network upgrade deployments - Add configuration system (BaseConfiguration, DevnetConfiguration) - Add TypeScript wrapper (forge_deploy.ts) for yarn-project integration Key fixes: - Use FOUNDRY_PROFILE=production to avoid mock BlobLib cheatcode issues - Use --force flag for clean recompilation with production profile - Fix slashingOffsetInRounds default from 0 to 2 The Forge deployment outputs JSON with contract addresses that maps to the existing L1ContractAddresses TypeScript type. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Merge forge_deploy.ts into deploy_l1_contracts.ts - Remove separate forge_deploy.ts file - Make Forge-based deployment the default - Simplify setup_l1_contracts.ts to only use Forge - Update CLI and local-network to use new unified API - Add --non-interactive flag to Forge commands for programmatic execution 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…racts Removes the alias and directly names the function deployL1Contracts as the main entry point for L1 contract deployment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ludamad
force-pushed
the
ad/feat/consolidate-network-upgrade-infrastructure
branch
from
9ff27f7 to
1a8d444
Compare
Add feeJuicePortalInitialBalance parameter to fund the fee juice portal during Forge-based L1 deployments. This enables e2e tests to work correctly by ensuring accounts can be funded with fee juice. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ludamad
requested review from
LHerskind,
Maddiaa0 and
just-mitch
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate network upgrade and contract deployment infrastructure by adopting forge scripts from the ignition-monorepo as the primary deployment method. This addresses configuration errors and clarity around deployment responsibilities by establishing a single, robust deployment path. Design and document the new infrastructure, including how contract code will be organized, e2e test integration, and command interfaces for running network upgrades.