feat(avm): TS triggers C++ simulation with an associated log level #18618
+85
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
force-pushed
the
db/cpp-loglevels
branch
from
1eadcd2 to
58f821c
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
60287d9 to
3c39514
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
from
58f821c to
888bdb7
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
3c39514 to
a61c2c5
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
from
888bdb7 to
0678fbd
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
a61c2c5 to
5f59918
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
from
0678fbd to
988d674
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
5f59918 to
2921aea
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
from
988d674 to
e3a4375
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
2921aea to
ca9c440
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
2 times, most recently
from
dcb1d94 to
01981b4
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
ca9c440 to
673ff4e
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
from
01981b4 to
a3a377f
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
2 times, most recently
from
25937e8 to
663067a
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
from
a3a377f to
4218dfb
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
663067a to
ebe2457
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
from
4218dfb to
3e7ea8f
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
ebe2457 to
1a3c4e4
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
2 times, most recently
from
d770052 to
6d57f79
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
1a3c4e4 to
d2093e5
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
d2093e5 to
faf8cb1
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
from
6d57f79 to
7cbefbb
Compare
dbanks12
force-pushed
the
db/cpp-loglevels
branch
from
7cbefbb to
543b06d
Compare
dbanks12
force-pushed
the
db/cpp-split
branch
from
faf8cb1 to
1c44c09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass TS log level through NAPI to C++. Unfortunately C++ doesn't have the same granularity of verbosity. And debugs only work if compiled for debug. But I still think we want LL plumbed. We can later decide if we want to use the same levels as TS.