fix(spartan): rename upgrade_via_cli back to upgrade_rollup_version and add prover milestone

Author: ludamad

spartan/bootstrap.sh

@@ -77,7 +77,7 @@ _emit_test() { echo "$_test_cmd_prefix $_test_cmd_run src/spartan/$1"; }
 function network_test_cmds_1 {
   _emit_test smoke.test.ts
   _emit_test reorg.test.ts
-  _emit_test upgrade_via_cli.test.ts
+  _emit_test upgrade_rollup_version.test.ts
   _emit_test validator_ha.test.ts
 }
 
@@ -289,7 +289,7 @@ case "$cmd" in
     source_network_env kind-provers
     namespace="upgrade-rollup-version${NAME_POSTFIX:-}"
     INSTALL_METRICS=false \
-      ./scripts/test_kind.sh src/spartan/upgrade_via_cli.test.ts "$namespace"
+      ./scripts/test_kind.sh src/spartan/upgrade_rollup_version.test.ts "$namespace"
     ;;
   "network_teardown")
     env_file="$1"

spartan/scripts/k8s_enricher.ts

@@ -169,6 +169,7 @@ const MILESTONE_PATTERNS = [
   /Published epoch proof/,
   /Updated proven chain to checkpoint/,
   /Downloaded checkpoint/,
+  /Job id=\S+ type=\S+ completed/,
 ];
 
 const LIFECYCLE_REASONS = new Set([

…-end/src/spartan/upgrade_via_cli.test.ts …c/spartan/upgrade_rollup_version.test.tsyarn-project/end-to-end/src/spartan/upgrade_via_cli.test.ts renamed to yarn-project/end-to-end/src/spartan/upgrade_rollup_version.test.ts yarn-project/end-to-end/src/spartan/upgrade_via_cli.test.ts renamed to yarn-project/end-to-end/src/spartan/upgrade_rollup_version.test.ts

@@ -31,7 +31,7 @@ import {
 
 const config = setupEnvironment(process.env);
 
-const debugLogger = createLogger('e2e:spartan-test:upgrade_via_cli');
+const debugLogger = createLogger('e2e:spartan-test:upgrade_rollup_version');
 
 /**
  * Deployment result from the deploy_rollup_upgrade.sh script.
@@ -104,7 +104,7 @@ function bumpManaTargetInNetworkDefaults(currentManaTarget: bigint): () => void
 
 // This test deploys a new rollup version using the deploy_rollup_upgrade.sh script
 // and goes through the governance process to register it
-describe('spartan_upgrade_via_cli', () => {
+describe('spartan_upgrade_rollup_version', () => {
   let aztecNode: AztecNode;
   let nodeInfo: NodeInfo;
   let ETHEREUM_HOSTS: string[];
@@ -139,7 +139,7 @@ describe('spartan_upgrade_via_cli', () => {
   it('should deploy a new rollup via deploy script and upgrade via governance', async () => {
     const chain = createEthereumChain(ETHEREUM_HOSTS, nodeInfo.l1ChainId);
 
-    // Derive private key from mnemonic (same as upgrade_rollup_version.test.ts)
+    // Derive private key from mnemonic
     const hdAccount = mnemonicToAccount(MNEMONIC, { addressIndex: 0 });
     const hdKey = hdAccount.getHdKey();
     if (!hdKey.privateKey) {
@@ -652,6 +652,6 @@ describe('spartan_upgrade_via_cli', () => {
       ),
     ).resolves.toBe(true);
 
-    debugLogger.info('Successfully verified new rollup is producing and proving blocks via CLI deploy');
+    debugLogger.info('Successfully verified new rollup is producing and proving blocks');
   });
 });