Skip to content

chore(deps): Bump criterion from 0.5.1 to 0.8.2#53

Closed
dependabot[bot] wants to merge 5 commits into
mainfrom
dependabot/cargo/criterion-0.8.2
Closed

chore(deps): Bump criterion from 0.5.1 to 0.8.2#53
dependabot[bot] wants to merge 5 commits into
mainfrom
dependabot/cargo/criterion-0.8.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github May 11, 2026 •
edited
Loading

Bumps criterion from 0.5.1 to 0.8.2.

Release notes

Sourced from criterion's releases.

criterion-plot-v0.8.2

Other

  • Update Readme

criterion-v0.8.2

Fixed

  • don't build alloca on unsupported targets

Other

  • (deps) bump crate-ci/typos from 1.40.0 to 1.43.0
  • Fix panic with uniform iteration durations in benchmarks
  • Update Readme
  • Exclude development scripts from published package

criterion-plot-v0.8.1

Fixed

  • Typo

criterion-v0.8.1

Fixed

  • Homepage link

Other

  • (deps) bump crate-ci/typos from 1.23.5 to 1.40.0
  • (deps) bump jontze/action-mdbook from 3 to 4
  • (deps) bump actions/checkout from 4 to 6

criterion-plot-v0.8.0

No release notes provided.

criterion-v0.8.0

BREAKING

  • Drop async-std support

Changed

  • Bump MSRV to 1.86, stable to 1.91.1

Added

  • Add ability to plot throughput on summary page.
  • Add support for reporting throughput in elements and bytes - Throughput::ElementsAndBytes allows the text summary to report throughput in both units simultaneously.
  • Add alloca-based memory layout randomisation to mitigate memory effects on measurements.

... (truncated)

Changelog

Sourced from criterion's changelog.

0.8.2 - 2026-02-04

Fixed

  • don't build alloca on unsupported targets

Other

  • (deps) bump crate-ci/typos from 1.40.0 to 1.43.0
  • Fix panic with uniform iteration durations in benchmarks
  • Update Readme
  • Exclude development scripts from published package

0.8.1 - 2025-12-07

Fixed

  • Homepage link

Other

  • (deps) bump crate-ci/typos from 1.23.5 to 1.40.0
  • (deps) bump jontze/action-mdbook from 3 to 4
  • (deps) bump actions/checkout from 4 to 6

0.8.0 - 2025-11-29

BREAKING

  • Drop async-std support

Changed

  • Bump MSRV to 1.86, stable to 1.91.1

Added

  • Add ability to plot throughput on summary page.
  • Add support for reporting throughput in elements and bytes - Throughput::ElementsAndBytes allows the text summary to report throughput in both units simultaneously.
  • Add alloca-based memory layout randomisation to mitigate memory effects on measurements.
  • Add doc comment to benchmark runner in criterion_group macro (removes linter warnings)

Fixed

  • Fix plotting NaN bug

Other

  • Remove Master API Docs links temporarily while we restore the docs publishing.

... (truncated)

Commits
  • 7f0d745 chore: release v0.8.2
  • 4a467ce chore(deps): bump crate-ci/typos from 1.40.0 to 1.43.0
  • b277a75 Fix panic with uniform iteration durations in benchmarks
  • 828af14 fix: don't build alloca on unsupported targets
  • b01316b Update Readme
  • 4c02a3b Exclude development scripts from published package
  • e4e06df chore: release v0.8.1
  • aa548b9 fix: Homepage link
  • 950c3b7 fix: Typo
  • 7e3e50c chore(deps): bump crate-ci/typos from 1.23.5 to 1.40.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
chore(deps): Bump criterion from 0.5.1 to 0.8.2
627c0eb 
Bumps [criterion](https://github.com/criterion-rs/criterion.rs) from 0.5.1 to 0.8.2.
- [Release notes](https://github.com/criterion-rs/criterion.rs/releases)
- [Changelog](https://github.com/criterion-rs/criterion.rs/blob/master/CHANGELOG.md)
- [Commits](criterion-rs/criterion.rs@0.5.1...criterion-v0.8.2)

---
updated-dependencies:
- dependency-name: criterion
  dependency-version: 0.8.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github May 11, 2026

Labels

The following labels could not be found: dependencies, rust. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@dependabot dependabot Bot requested review from AzeezIsh and tbraun96 as code owners May 11, 2026 07:35
@tbraun96
Copy link
Copy Markdown
Contributor

tbraun96 commented Jun 3, 2026

The criterion 0.8 bump itself is good: I verified atlas-spark-bench --benches --tests compiles cleanly against criterion 0.8.2 / criterion-plot 0.8.2, so the API change is absorbed with no code edits needed. The only blocker is that this branch's Cargo.lock has drifted behind main (a cargo build --locked on the merge result fails because the lock is missing the new transitive deps like alloca/page_size). Regenerating the lock against current main will make it mergeable.

@dependabot rebase

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Jun 3, 2026

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@tbraun96 tbraun96 mentioned this pull request Jun 3, 2026
Merged
tbraun96 added a commit that referenced this pull request Jun 3, 2026
@tbraun96 @AzeezIsh
chore(deps): bump criterion 0.5 -> 0.8 (completes #53) (#120)
78659fc 
Dependabot's #53 only bumped atlas-spark-bench, but xgrammar also depends
on criterion, so the lock could not resolve (xgrammar pinned ^0.5 while
atlas-spark-bench wanted 0.8). Bump both crates and regenerate only the
criterion + criterion-plot lock entries (targeted, no incidental dep
churn). Verified the xgrammar and atlas-spark-bench bench/test suites
compile against criterion 0.8.2 with no API changes needed. Benchmark-only
dev-dependency, zero runtime impact.

Co-authored-by: Azeez Ishaqui <debaterishaqui@gmail.com>
@tbraun96
Copy link
Copy Markdown
Contributor

tbraun96 commented Jun 3, 2026

Superseded by the completed bump in the PR above: your bump was correct but only touched atlas-spark-bench, and xgrammar also depends on criterion, so the lock could not resolve until both were moved to 0.8 together. Folded both in and verified the bench suites compile against 0.8.2. Thanks dependabot.

@tbraun96 tbraun96 closed this Jun 3, 2026
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Jun 3, 2026

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot Bot deleted the dependabot/cargo/criterion-0.8.2 branch June 3, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbraun96 tbraun96 Awaiting requested review from tbraun96 tbraun96 is a code owner

@AzeezIsh AzeezIsh Awaiting requested review from AzeezIsh AzeezIsh is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tbraun96