Premium Content: Correct "non-static method call" errors. #44243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kwight
changed the title
kwight
added
Premium Content
Contributor
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Contributor
|
Caution: This PR affects files in the FSE Plugin on WordPress.com D46534-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2 |
gwwar
reviewed
Jul 16, 2020
...ing-plugin/premium-content/subscription-service/class-jetpack-token-subscription-service.php
Show resolved
Hide resolved
Contributor
Author
|
This still leaves the "header information" issues:
|
Contributor
|
Going to help land to help clear up the team board. |
matticbot
removed
the
[Status] Needs Review
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Premium Content block causes log errors by calling a non-static method statically to get tokens. This PR corrects the code usage to avoid the errors.
Discovered by @blackjackkent while testing #44192 .
Testing Instructions
FSE plugin / Build FSE plugin (pull_request)task below as a ZIP plugin that you can upload to the test site.