Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: add location views query hook #97951

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Conversation

Initsogar
Copy link
Contributor

@Initsogar Initsogar commented Jan 4, 2025

Resolves to https://github.com/Automattic/jetpack-roadmap/issues/2095

Proposed Changes

  • Add useLocationViewsQuery hook in client/my-sites/stats/hooks/use-location-views-query.ts.
  • Abstract logic for fetching location-based (country, region, city) view stats into the new hook.
  • Update relevant components to use the new hook, guarded by the stats/location feature flag to prevent any unintended impact on production users.

CleanShot 2025-01-05 at 15 48 30@2x

Why are these changes being made?

p1HpG7-rpL-p2

Testing Instructions

Note

This can only be tested on WPCOM using Calypso Blue, which is suitable for the initial development process. We can begin testing it on Odyssey once the location-views API is implemented in the Jetpack API: Automattic/jetpack#40852

  1. Setup:

    • Spin up a Calypso Live branch with the latest changes.
  2. Enable the Feature:

    • Navigate to the Stats traffic page.
    • Append ?flags=stats/locations to the URL to enable the stats/location feature flag.
  3. Verify UI Changes:

    • You should see the new Locations section on the page.
    • The section should render the country visits list as shown in the provided screenshot.
  4. Validate API Calls:

    • Open your browser's Network tab.
    • Confirm that the page is making requests to the stats/location-views/% endpoint and that the responses are as expected.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 4, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/stats-locations-countries on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 4, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~166 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +485 B  (+0.0%)     +166 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@Initsogar Initsogar added the [Feature] Stats Everything related to our analytics product at /stats/ label Jan 5, 2025
@Initsogar Initsogar changed the title Stats: add locations query hook Stats: add location views query hook Jan 5, 2025
@Initsogar Initsogar requested a review from a team January 5, 2025 21:07
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 5, 2025
@Initsogar Initsogar requested a review from a team January 5, 2025 21:07
@Initsogar Initsogar marked this pull request as ready for review January 5, 2025 21:07
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and works well 👍

@Initsogar Initsogar merged commit 8be8e8b into trunk Jan 6, 2025
18 checks passed
@Initsogar Initsogar deleted the add/stats-locations-countries branch January 6, 2025 12:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants