-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: add location views query hook #97951
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~166 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good and works well 👍
Resolves to https://github.com/Automattic/jetpack-roadmap/issues/2095
Proposed Changes
useLocationViewsQuery
hook inclient/my-sites/stats/hooks/use-location-views-query.ts
.stats/location
feature flag to prevent any unintended impact on production users.Why are these changes being made?
p1HpG7-rpL-p2
Testing Instructions
Note
This can only be tested on WPCOM using Calypso Blue, which is suitable for the initial development process. We can begin testing it on Odyssey once the
location-views
API is implemented in the Jetpack API: Automattic/jetpack#40852Setup:
Enable the Feature:
?flags=stats/locations
to the URL to enable thestats/location
feature flag.Verify UI Changes:
Validate API Calls:
stats/location-views/%
endpoint and that the responses are as expected.Pre-merge Checklist