Agents Manager: Restrict zoom action to editor pages#109908
Merged
Conversation
The zoom action button was appearing on all pages, but it should only be available on editor pages (site editor, post/page editor) where show_component tool messages are meaningful. Also aligns the action id with the convention used by other message action hooks. BSKY-1892 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
There was a problem hiding this comment.
Pull request overview
Restricts the “zoom” message action so it only appears in relevant WordPress editor contexts, and standardizes the action identifier to match other message action hooks.
Changes:
- Add an
isEditorPage()guard so zoom actions are only registered for editor pages (site editor / post editor contexts). - Rename the action
idfromzoom-toggletozoomto align with other action IDs (copy,checkpoint,sources).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of BSKY-1892
Proposed Changes
isEditorPage()guard to the zoom action hook so the zoom button only appears on editor pages (site editor, post/page editor).idfromzoom-toggletozoom, matching the convention used by other message action hooks (copy,checkpoint,sources).Why are these changes being made?
The zoom action button was appearing on all pages, including non-editor contexts where
show_componenttool messages are not meaningful. This restricts it to editor pages only.Testing Instructions
A minor fixing, will do self-review, test, and then merge.
Pre-merge Checklist