MSD: refactor interim omnibar: extract store and events#109906
Merged
Conversation
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
p-jackson
approved these changes
Apr 9, 2026
Member
p-jackson
left a comment
There was a problem hiding this comment.
Yes! This has grown into a lot more than just "click handlers" 😄
Thanks for the tidy up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
click-handlers.tstoomnibar-events.tsnotificationsAnchor(Dashboard: Anchor notifications popover when toggled via 'n' shortcut #109826)notificationsUnseenCount(MSD: wire up unseen notification dot icon logic in interim omnibar #109858)createOmnibarStorefrominterim-omnibar.tsxintoomnibar-store.tsNOTIFICATIONS_UNSEEN_COUNT_SETaction (MSD: wire up unseen notification dot icon logic in interim omnibar #109858).tslogic from.tsx, and to make it symmetrical toomnibar-events.tsabove.Why are these changes being made?
Making me less dizzy.
Testing Instructions
Verify no regressions.
Pre-merge Checklist