Skip to content

MSD: refactor interim omnibar: extract store and events#109906

Merged
fushar merged 1 commit intotrunkfrom
omnibar-refactor
Apr 9, 2026
Merged

MSD: refactor interim omnibar: extract store and events#109906
fushar merged 1 commit intotrunkfrom
omnibar-refactor

Conversation

@fushar
Copy link
Copy Markdown
Contributor

@fushar fushar commented Apr 9, 2026

Proposed Changes

Why are these changes being made?

Making me less dizzy.

Testing Instructions

Verify no regressions.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Copy Markdown
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • agents-manager
  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug omnibar-refactor on your sandbox.

@fushar fushar marked this pull request as ready for review April 9, 2026 06:32
@fushar fushar requested a review from a team as a code owner April 9, 2026 06:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 9, 2026
@fushar fushar self-assigned this Apr 9, 2026
Copy link
Copy Markdown
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This has grown into a lot more than just "click handlers" 😄

Thanks for the tidy up.

@fushar fushar merged commit f0145af into trunk Apr 9, 2026
19 checks passed
@fushar fushar deleted the omnibar-refactor branch April 9, 2026 06:56
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants