Fix/issue WOOSHIP-1717 - Change priority for print notices method (#2895)

* add priority for print notices method

* add changelog

* fix the destination address setter on the phpunit test

* edit changelog

* Update changelog

* ensure all of the response body variable is set

* throw exception if one of the response body tax is not set

* remove the true condition and use json_encode for has_nexus

* use json_encode for has_nexus in throw exception

* small grammar fix

* changelog adjustments

---------

Co-authored-by: Dustin Parker <[email protected]>

Author: iyut

changelog.txt

@@ -1,8 +1,11 @@
 *** WooCommerce Tax Changelog ***
 
+= 3.2.2 - 2025-xx-xx =
+* Fix   - Display TaxJar error notices only after taxes are calculated.
+* Tweak - Log detection of potential incorrect California tax nexus in successful TaxJar API and cached responses.
+
 = 3.2.1 - 2025-11-03 =
 * Fix   - Exclude shipping-related admin components when shipping functionality is disabled.
-* Tweak - Add logging check for incorrect California tax nexus in the TaxJar API response or cached response.
 
 = 3.2.0 - 2025-10-14 =
 * Fix   - No tax calculated for multi-word state/counties.

classes/class-wc-connect-taxjar-integration.php

@@ -1628,21 +1628,25 @@ private function check_for_incorrect_california_tax_nexus( $response_body, $cach
 			$log_suffix    = 'in cached response.';
 		}
 
-		$to_state   = $response_body->tax->jurisdictions->state;
-		$to_country = $response_body->tax->jurisdictions->country;
-		$has_nexus  = $response_body->tax->has_nexus;
+		$to_state   = isset( $response_body->tax->jurisdictions->state ) ? $response_body->tax->jurisdictions->state : 'not set';
+		$to_country = isset( $response_body->tax->jurisdictions->country ) ? $response_body->tax->jurisdictions->country : 'not set';
+		$has_nexus  = isset( $response_body->tax->has_nexus ) ? $response_body->tax->has_nexus : null;
 
 		if ( 'CA' === $to_state && 'US' === $to_country && true === $has_nexus ) {
 			$this->_log(
 				sprintf(
-					'Incorrect California tax nexus detected %s (from_state: %s, to_state: %s, to_country: %s, has_nexus: %s).',
+					'Incorrect California tax nexus detected %1$s (from_state: %2$s, to_state: %3$s, to_country: %4$s, has_nexus: %5$s).',
 					$log_suffix,
 					$from_state ?: 'unknown',
 					$to_state,
 					$to_country,
-					$has_nexus ? 'true' : 'false'
+					json_encode( $has_nexus ),
 				)
 			);
 		}
+
+		if ( 'not set' === $to_state || 'not set' === $to_country || null === $has_nexus ) {
+			throw new Exception( sprintf( 'One or more values are not set : to_state=>%1$s, to_country=>%2$s, has_nexus=>%3$s', $to_state, $to_country, json_encode( $has_nexus ) ) );
+		}
 	}
 }

readme.txt

@@ -70,9 +70,12 @@ This plugin relies on the following external services:
 
 == Changelog ==
 
+= 3.2.2 - 2025-xx-xx =
+* Fix   - Display TaxJar error notices only after taxes are calculated.
+* Tweak - Log detection of potential incorrect California tax nexus in successful TaxJar API and cached responses.
+
 = 3.2.1 - 2025-11-03 =
 * Fix   - Exclude shipping-related admin components when shipping functionality is disabled.
-* Tweak - Add logging check for incorrect California tax nexus in the TaxJar API response or cached response.
 
 = 3.2.0 - 2025-10-14 =
 * Fix   - No tax calculated for multi-word state/counties.

src/StoreNotices/StoreNoticesController.php

@@ -34,7 +34,7 @@ class StoreNoticesController {
 	public function __construct( StoreNoticesNotifier $notifier ) {
 		$this->notifier = $notifier;
 
-		add_action( 'woocommerce_after_calculate_totals', array( $this, 'maybe_display_notices' ) );
+		add_action( 'woocommerce_after_calculate_totals', array( $this, 'maybe_display_notices' ), 30 );
 		add_filter( 'woocommerce_store_api_cart_errors', array( $this, 'add_store_api_cart_errors' ), 10, 2 );
 	}
 

tests/bin/install-wc-tests.sh

@@ -10,7 +10,7 @@ DB_USER=$2
 DB_PASS=$3
 DB_HOST=${4-localhost}
 WP_VERSION=${5-latest}
-WC_VERSION=${6-"7.4.1"}
+WC_VERSION=${6-"10.3.4"}
 
 export NVM_DIR="$HOME/.nvm"
 [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm