Skip to content

Conversation

@t-wright
Copy link
Contributor

@t-wright t-wright commented Feb 2, 2026

Proposed changes:

  • Passes mediaProps to <MediaSources /> component when rendered by the "replace" button in the block toolbar. This is required for the jetpack.externalMedia.extraMediaSources filter to work correctly in this context.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

FORNO-177

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Checkout this PR on your sandbox using the instructions in this comment
  • Go to the post editor and add an image block to the post
  • In your browser console run this:
wp.hooks.addFilter( "jetpack.externalMedia.extraMediaSources", "myplugin", ( value, args ) => {
	return [{
		id: "myplugin-extra-source",
		label: "My Source",
		icon: "admin-site",
		onClick: () => {
		        const image = { id: 123, url: "https://example.com/image.jpg" }; // update this with an actual image attachment
			args.onSelect( args.multiple ? [ image ] : image );
		}
	}];
} );
  • Click Replace from the image block toolbar and choose My Source
  • Verify the block was updated with the specified attachment

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the forno-177/fix/generate-image-from-replace-button branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack forno-177/fix/generate-image-from-replace-button

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Feb 2, 2026
@jp-launch-control
Copy link

jp-launch-control bot commented Feb 2, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@t-wright t-wright force-pushed the forno-177/fix/generate-image-from-replace-button branch from fae62b0 to b7800fd Compare February 2, 2026 03:06
@t-wright t-wright marked this pull request as ready for review February 2, 2026 04:08
@t-wright t-wright requested a review from ariskataoka February 2, 2026 04:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the mediaProps prop was not being passed to the MediaSources component in two specific contexts: the MediaReplaceFlow (toolbar replace button) and the replace button in media-menu.js. This caused the jetpack.externalMedia.extraMediaSources filter to receive undefined values for allowedTypes, multiple, and onSelect properties in these contexts, breaking custom media sources added via this filter.

Changes:

  • Added mediaProps prop to MediaSources component in the MediaReplaceFlow filter context
  • Added mediaProps prop to MediaSources component in the isReplace branch of MediaButtonMenu

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
projects/packages/external-media/src/features/editor/index.js Passes mediaProps={ props } to MediaSources component in MediaReplaceFlow filter to enable the extraMediaSources filter to work correctly
projects/packages/external-media/src/shared/media-button/media-menu.js Passes mediaProps={ mediaProps } to MediaSources component in the replace flow branch
projects/packages/external-media/changelog/fix-missing-media-sources-prop Adds changelog entry documenting the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] External Media [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants