Address review feedback: cache connection manager, add user-not-connected test, fix changelog

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: dhasilva

projects/packages/admin-ui/changelog/update-upsell-sidebar-hide-when-not-connected

@@ -1,4 +1,4 @@
 Significance: minor
 Type: changed
 
-Sidebar upsell: hide when site is not connected to Jetpack.com.
+Hide the sidebar upsell when the site is not connected to Jetpack or is in offline mode.

projects/packages/admin-ui/src/class-admin-menu.php

@@ -304,7 +304,8 @@ private static function should_show_upgrade_menu() {
 	private static function is_site_and_user_connected() {
 		$connection_manager = self::$connection_manager;
 		if ( ! $connection_manager && class_exists( '\Automattic\Jetpack\Connection\Manager' ) ) {
-			$connection_manager = new \Automattic\Jetpack\Connection\Manager();
+			$connection_manager       = new \Automattic\Jetpack\Connection\Manager();
+			self::$connection_manager = $connection_manager;
 		}
 
 		if (

projects/packages/admin-ui/tests/php/Admin_Menu_Test.php

@@ -397,6 +397,26 @@ public function test_upgrade_menu_item_hidden_when_site_not_connected() {
 		$this->assertUpgradeMenuItemAbsent();
 	}
 
+	/**
+	 * Upgrade item is absent when the user is not connected (site is connected).
+	 *
+	 * @return void
+	 */
+	public function test_upgrade_menu_item_hidden_when_user_not_connected() {
+		wp_set_current_user( self::$admin_user_id );
+		$connection = $this->getMockBuilder( 'Automattic\Jetpack\Connection\Manager' )
+			->disableOriginalConstructor()
+			->getMock();
+		$connection->method( 'is_connected' )->willReturn( true );
+		$connection->method( 'is_user_connected' )->willReturn( false );
+		Admin_Menu::set_connection_manager( $connection );
+
+		Admin_Menu::init();
+		do_action( 'admin_menu' );
+
+		$this->assertUpgradeMenuItemAbsent();
+	}
+
 	/**
 	 * Upgrade item is absent when the site is in offline (development) mode.
 	 *