Forms: Create a new page instead of post when creating a new form from dashboard (#43668)

* create page instead of post

* check page editing capability and respond with errors

* changelog

Author: dhasilva

projects/packages/forms/changelog/update-forms-create-page

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Forms: Create a new page instead of post when creating a new form from dashboard

projects/packages/forms/src/contact-form/class-contact-form-plugin.php

@@ -1965,11 +1965,21 @@ public function download_feedback_as_csv() {
 	}
 
 	/**
-	 * Create a new post with a Form block
+	 * Create a new page with a Form block
 	 */
 	public function create_new_form() {
 		if ( ! isset( $_POST['newFormNonce'] ) || ! wp_verify_nonce( sanitize_text_field( wp_unslash( $_POST['newFormNonce'] ) ), 'create_new_form' ) ) {
-			wp_die( esc_html__( 'Invalid nonce', 'jetpack-forms' ) );
+			wp_send_json_error(
+				__( 'Invalid nonce', 'jetpack-forms' ),
+				403
+			);
+		}
+
+		if ( ! current_user_can( 'edit_pages' ) ) {
+			wp_send_json_error(
+				__( 'You do not have permission to create pages', 'jetpack-forms' ),
+				403
+			);
 		}
 
 		$pattern_name = isset( $_POST['pattern'] ) ? sanitize_text_field( wp_unslash( $_POST['pattern'] ) ) : null;
@@ -1988,20 +1998,24 @@ public function create_new_form() {
 
 		$post_id = wp_insert_post(
 			array(
+				'post_type'    => 'page',
 				'post_title'   => esc_html__( 'Jetpack Forms', 'jetpack-forms' ),
 				'post_content' => $pattern_content,
 			)
 		);
 
-		if ( ! is_wp_error( $post_id ) ) {
-			$array_result = array(
-				'post_url' => admin_url( 'post.php?post=' . intval( $post_id ) . '&action=edit' ),
+		if ( is_wp_error( $post_id ) ) {
+			wp_send_json_error(
+				$post_id->get_error_message(),
+				500
+			);
+		} else {
+			wp_send_json(
+				array(
+					'post_url' => admin_url( 'post.php?post=' . intval( $post_id ) . '&action=edit' ),
+				)
 			);
-
-			wp_send_json( $array_result );
 		}
-
-		wp_die();
 	}
 
 	/**

projects/packages/forms/src/dashboard/hooks/use-create-form.ts

@@ -35,21 +35,34 @@ export default function useCreateForm(): CreateFormReturn {
 		}
 
 		const response = await fetch( window.ajaxurl, { method: 'POST', body: data } );
-		const { post_url: postUrl }: { post_url: string } = await response.json();
+
+		const {
+			success,
+			post_url: postUrl,
+			data: message,
+		}: { success?: boolean; data?: string; post_url?: string } = await response.json();
+
+		if ( success === false ) {
+			throw new Error( message );
+		}
 
 		return postUrl;
 	}, [] );
 
 	const openNewForm = useCallback(
 		async ( { formPattern, showPatterns, analyticsEvent }: ClickHandlerProps ) => {
-			const postUrl = await createForm( formPattern );
+			try {
+				const postUrl = await createForm( formPattern );
 
-			if ( postUrl ) {
-				analyticsEvent?.( { formPattern } );
+				if ( postUrl ) {
+					analyticsEvent?.( { formPattern } );
 
-				window.open(
-					`${ postUrl }${ showPatterns && ! formPattern ? '&showJetpackFormsPatterns' : '' }`
-				);
+					window.open(
+						`${ postUrl }${ showPatterns && ! formPattern ? '&showJetpackFormsPatterns' : '' }`
+					);
+				}
+			} catch ( error ) {
+				console.error( error.message ); // eslint-disable-line no-console
 			}
 		},
 		[ createForm ]