Fix point instancer crash #4281
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
bug
pierrebai-adsk
force-pushed
the
bailp/2680/point-instancer-crash
branch
from
3973df4 to
2360884
Compare
Apply a fix similar to other palces in the same file. Not 100% it is entirely right, as my knowledge of the VP2 render delegate and instancer is not high.
pierrebai-adsk
force-pushed
the
bailp/2680/point-instancer-crash
branch
from
2360884 to
5486079
Compare
Collaborator
|
@pierrebai-adsk What should we do with this PR? |
Collaborator
Author
|
I kept it around to not lose info on what I tried, but as I said in my comments, it did not fix the problem. |
seando-adsk
added
the
do-not-merge-yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply a fix similar to other places in the same file. Not 100% it is entirely right, as my knowledge of the VP2 render delegate and instancer is not high.
Turns out this does not fix the crash... oh well