Merge pull request #208 from AthennaIO/develop

chore(driver): validate when statement is a string

Author: jlenon7

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@athenna/database",
-  "version": "5.28.0",
+  "version": "5.29.0",
   "description": "The Athenna database handler for SQL/NoSQL.",
   "license": "MIT",
   "author": "João Lenon <lenon@athenna.io>",

package.json

@@ -929,6 +929,16 @@ export class MySqlDriver extends Driver<Knex, Knex.QueryBuilder> {
     }
 
     if (operation === undefined) {
+      if (Is.Array(statement)) {
+        throw new Error('Arrays as statement are not supported.')
+      }
+
+      if (Is.String(statement)) {
+        throw new Error(
+          `The value for the "${statement}" column is undefined and where will not work.`
+        )
+      }
+
       this.qb.where(statement)
 
       return this

src/database/drivers/MySqlDriver.ts

@@ -923,6 +923,16 @@ export class PostgresDriver extends Driver<Knex, Knex.QueryBuilder> {
     }
 
     if (operation === undefined) {
+      if (Is.Array(statement)) {
+        throw new Error('Arrays as statement are not supported.')
+      }
+
+      if (Is.String(statement)) {
+        throw new Error(
+          `The value for the "${statement}" column is undefined and where will not work.`
+        )
+      }
+
       this.qb.where(statement)
 
       return this

src/database/drivers/PostgresDriver.ts

@@ -922,6 +922,16 @@ export class SqliteDriver extends Driver<Knex, Knex.QueryBuilder> {
     }
 
     if (operation === undefined) {
+      if (Is.Array(statement)) {
+        throw new Error('Arrays as statement are not supported.')
+      }
+
+      if (Is.String(statement)) {
+        throw new Error(
+          `The value for the "${statement}" column is undefined and where will not work.`
+        )
+      }
+
       this.qb.where(statement)
 
       return this

src/database/drivers/SqliteDriver.ts

@@ -29,7 +29,7 @@ export default class ModelGeneratorTest {
 
     const data = await new ModelGenerator(User, User.schema()).generateOne({ id: '1' })
 
-    assert.deepEqual(data, { id: '1' })
+    assert.containSubset(data, { id: '1' })
   }
 
   @Test()
@@ -41,7 +41,7 @@ export default class ModelGeneratorTest {
 
     const data = await new ModelGenerator(User, User.schema()).generateOne({ _id: '1' })
 
-    assert.deepEqual(data, { id: '1' })
+    assert.containSubset(data, { id: '1' })
   }
 
   @Test()
@@ -65,7 +65,7 @@ export default class ModelGeneratorTest {
 
     const data = await new ModelGenerator(User, User.schema()).generateMany([{ id: '1' }])
 
-    assert.deepEqual(data, [{ id: '1' }])
+    assert.containSubset(data, [{ id: '1' }])
   }
 
   @Test()
@@ -77,7 +77,7 @@ export default class ModelGeneratorTest {
 
     const data = await new ModelGenerator(User, User.schema()).generateMany([{ _id: '1' }])
 
-    assert.deepEqual(data, [{ id: '1' }])
+    assert.containSubset(data, [{ id: '1' }])
   }
 
   @Test()
@@ -127,7 +127,7 @@ export default class ModelGeneratorTest {
 
     const data = await new ModelGenerator(User, schema).generateOne({ _id: '1' })
 
-    assert.deepEqual(data, { id: '1', profile: { userId: '1' } })
+    assert.containSubset(data, { id: '1', profile: { userId: '1' } })
   }
 
   @Test()
@@ -153,7 +153,7 @@ export default class ModelGeneratorTest {
 
     const data = await new ModelGenerator(User, schema).generateOne({ _id: '1' })
 
-    assert.deepEqual(data, { id: '1' })
+    assert.containSubset(data, { id: '1' })
   }
 
   @Test()
@@ -177,7 +177,7 @@ export default class ModelGeneratorTest {
 
     const data = await new ModelGenerator(User, schema).generateMany([{ _id: '1' }])
 
-    assert.deepEqual(data, [{ id: '1', profile: { userId: '1' } }])
+    assert.containSubset(data, [{ id: '1', profile: { userId: '1' } }])
   }
 
   @Test()
@@ -201,6 +201,6 @@ export default class ModelGeneratorTest {
 
     const data = await new ModelGenerator(User, schema).generateMany([{ _id: '1' }])
 
-    assert.deepEqual(data, [{ id: '1' }])
+    assert.containSubset(data, [{ id: '1' }])
   }
 }