Optimize MD5 computations in tests

Author: slandelle

client/src/test/java/org/asynchttpclient/reactivestreams/ReactiveStreamsTest.java

@@ -14,7 +14,7 @@
 
 import static io.netty.handler.codec.http.HttpHeaderNames.*;
 import static org.asynchttpclient.Dsl.*;
-import static org.asynchttpclient.test.TestUtils.LARGE_IMAGE_BYTES;
+import static org.asynchttpclient.test.TestUtils.*;
 import static org.testng.Assert.assertEquals;
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
@@ -222,11 +222,10 @@ public void testStreamingPutImage() throws Exception {
     public void testConnectionDoesNotGetClosed() throws Exception {
         // test that we can stream the same request multiple times
         try (AsyncHttpClient client = asyncHttpClient(config().setRequestTimeout(100 * 6000))) {
-            String expectedMd5 = TestUtils.md5(LARGE_IMAGE_BYTES);
             BoundRequestBuilder requestBuilder = client.preparePut(getTargetUrl())//
                     .setBody(createPublisher(LARGE_IMAGE_BYTES, 1000))//
                     .setHeader("X-" + CONTENT_LENGTH, LARGE_IMAGE_BYTES.length)//
-                    .setHeader("X-" + CONTENT_MD5, expectedMd5);
+                    .setHeader("X-" + CONTENT_MD5, LARGE_IMAGE_BYTES_MD5);
 
             Response response = requestBuilder.execute().get();
             assertEquals(response.getStatusCode(), 200, "HTTP response was invalid on first request.");
@@ -235,8 +234,8 @@ public void testConnectionDoesNotGetClosed() throws Exception {
             responseBody = response.getResponseBodyAsBytes();
             assertEquals(Integer.valueOf(response.getHeader("X-" + CONTENT_LENGTH)).intValue(), LARGE_IMAGE_BYTES.length, "Server side payload length invalid");
             assertEquals(responseBody.length, LARGE_IMAGE_BYTES.length, "Client side payload length invalid");
-            assertEquals(response.getHeader(CONTENT_MD5), expectedMd5, "Server side payload MD5 invalid");
-            assertEquals(TestUtils.md5(responseBody), expectedMd5, "Client side payload MD5 invalid");
+            assertEquals(response.getHeader(CONTENT_MD5), LARGE_IMAGE_BYTES_MD5, "Server side payload MD5 invalid");
+            assertEquals(TestUtils.md5(responseBody), LARGE_IMAGE_BYTES_MD5, "Client side payload MD5 invalid");
             assertEquals(responseBody, LARGE_IMAGE_BYTES, "Image bytes are not equal on first attempt");
 
             response = requestBuilder.execute().get();
@@ -246,8 +245,8 @@ public void testConnectionDoesNotGetClosed() throws Exception {
             assertEquals(responseBody.length, LARGE_IMAGE_BYTES.length, "Client side payload length invalid");
 
             try {
-                assertEquals(response.getHeader(CONTENT_MD5), expectedMd5, "Server side payload MD5 invalid");
-                assertEquals(TestUtils.md5(responseBody), expectedMd5, "Client side payload MD5 invalid");
+                assertEquals(response.getHeader(CONTENT_MD5), LARGE_IMAGE_BYTES_MD5, "Server side payload MD5 invalid");
+                assertEquals(TestUtils.md5(responseBody), LARGE_IMAGE_BYTES_MD5, "Client side payload MD5 invalid");
                 assertEquals(responseBody, LARGE_IMAGE_BYTES, "Image bytes weren't equal on subsequent test");
             } catch (AssertionError e) {
                 e.printStackTrace();

client/src/test/java/org/asynchttpclient/test/TestUtils.java

@@ -61,6 +61,7 @@
 import org.asynchttpclient.SslEngineFactory;
 import org.asynchttpclient.netty.ssl.JsseSslEngineFactory;
 import org.asynchttpclient.util.Base64;
+import org.asynchttpclient.util.MessageDigestUtils;
 import org.eclipse.jetty.security.ConstraintMapping;
 import org.eclipse.jetty.security.ConstraintSecurityHandler;
 import org.eclipse.jetty.security.HashLoginService;
@@ -89,6 +90,7 @@ public class TestUtils {
     public static final byte[] PATTERN_BYTES = "FooBarBazQixFooBarBazQixFooBarBazQixFooBarBazQixFooBarBazQixFooBarBazQix".getBytes(Charset.forName("UTF-16"));
     public static final File LARGE_IMAGE_FILE;
     public static final byte[] LARGE_IMAGE_BYTES;
+    public static final String LARGE_IMAGE_BYTES_MD5;
     public static final File SIMPLE_TEXT_FILE;
     public static final String SIMPLE_TEXT_FILE_STRING;
     private static final LoginService LOGIN_SERVICE = new HashLoginService("MyRealm", "src/test/resources/realm.properties");
@@ -99,6 +101,7 @@ public class TestUtils {
             TMP_DIR.deleteOnExit();
             LARGE_IMAGE_FILE = resourceAsFile("300k.png");
             LARGE_IMAGE_BYTES = FileUtils.readFileToByteArray(LARGE_IMAGE_FILE);
+            LARGE_IMAGE_BYTES_MD5 = TestUtils.md5(LARGE_IMAGE_BYTES);
             SIMPLE_TEXT_FILE = resourceAsFile("SimpleTextFile.txt");
             SIMPLE_TEXT_FILE_STRING = FileUtils.readFileToString(SIMPLE_TEXT_FILE, UTF_8);
         } catch (Exception e) {
@@ -373,7 +376,7 @@ public static String md5(byte[] bytes) {
 
     public static String md5(byte[] bytes, int offset, int len) {
         try {
-            MessageDigest md = MessageDigest.getInstance("MD5");
+            MessageDigest md = MessageDigestUtils.pooledMd5MessageDigest();
             md.update(bytes, offset, len);
             return Base64.encode(md.digest());
         } catch (Exception e) {