fix(ui): restore shimmer for running trow summaries#883
Conversation
📝 WalkthroughWalkthroughSession-turn-trow-block now wraps active summary text with the TextShimmer component. The CSS documentation describes the shimmer behavior, and e2e snapshot tests validate that running trows display active shimmer while collapsed states remain still. ChangesTrow Summary Shimmer
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request integrates the TextShimmer component into the TrowBlock to handle loading states for summary text and updates the end-to-end tests to verify the shimmer's visibility. A review comment identifies that using the keyed attribute on the <Show> component causes unnecessary remounting, which triggers unwanted entry animations and breaks the internal transition logic of TextShimmer. It is recommended to remove the keyed attribute and treat the text as an accessor to ensure smoother visual transitions.
Perf delta summaryComparator: pass
|
Bump the desktop Electron package version to v2026.5.25 for the release train. Included release-readiness checks: - Local app and desktop Electron typechecks passed. - Focused UI component tests for grouped tool-call summaries passed. - PR CI passed, including app/ui/opencode/desktop units, typecheck, CodeQL, desktop smoke, and e2e-artifacts. - Computer Use manual E2E covered new session creation, an actual execute-command tool call, right-panel tabs and collapse, #880 sidebar/right-panel toggle affordances, and pinned session drag reordering. This release includes the current dev branch work through #880 and the later fixes #881 and #883.
Summary
Restore the shared
TextShimmertreatment for active trow summary text while keeping completed trow summaries stable.Why
Issue #882 tracks the follow-up from PR #874: grouped trow summaries expose running state, but the summary text was still rendered as plain text. This makes active tool-group changes feel abrupt and leaves the existing shimmer contract unused.
Related Issue
Fixes #882
Human Review Status
Approved by @Astro-Han
Review Focus
Please check that the shimmer is scoped only to active trow summary text and that completed summaries do not keep an active animation node.
Risk Notes
The change adds one shared TextShimmer instance to active trow summaries, so the main risk is render/perf cost during tool-heavy sessions. Targeted snap and perf probe scenarios passed. Platform/packaging checklist item is unticked because this touches only web-rendered UI component code and snap coverage.
How To Verify
Screenshots or Recordings
Updated snap target:
session-trow, generateddocs/design/preview/screenshots/session-trow.png.Manual Electron check passed by @Astro-Han.
Checklist
bug,enhancement,task,documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.app,ui,platform,harness,ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.P0,P1,P2,P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.Pending,Approved by @<reviewer>, orNot required: <reason>(default isPending; "not required" is restricted to bot-authored low-risk PRs).dev, and my PR title and commit messages use Conventional Commits in English.Summary by CodeRabbit
Release Notes
New Features
Tests