fix(ui): initialize turn change visibility after working state

Author: Astro-Han

packages/ui/src/components/session-turn-parent.test.ts

@@ -29,3 +29,9 @@ test("turn-change expansion state stays owned by session turn", () => {
   expect(turnSource).toContain("onExpandedChange={(value) => setTurnExpanded(value)}")
   expect(panelSource).not.toContain("const [turnExpanded, setTurnExpanded] = createSignal<string[]>([])")
 })
+
+test("visible turn-change memo is declared after working state", () => {
+  const source = readFileSync(new URL("./session-turn.tsx", import.meta.url), "utf8")
+
+  expect(source.indexOf("const working = createMemo")).toBeLessThan(source.indexOf("const visibleTurnChange = createMemo"))
+})

packages/ui/src/components/session-turn.tsx

@@ -294,11 +294,6 @@ export function SessionTurn(
     if (!messages.length) return false
     return messages.some((item) => typeof item.time.completed !== "number")
   })
-  const visibleTurnChange = createMemo(() => {
-    const current = turnChange()
-    if (!hasVisibleTurnChanges(current) || working() || turnInProgress()) return
-    return current
-  })
   const interrupted = createMemo(() => assistantMessages().some((m) => m.error?.name === "MessageAbortedError"))
   const divider = createMemo(() => {
     if (compaction()) return i18n.t("ui.messagePart.compaction")
@@ -339,6 +334,11 @@ export function SessionTurn(
     return data.store.session_status[props.sessionID] ?? idle
   })
   const working = createMemo(() => status().type !== "idle" && active())
+  const visibleTurnChange = createMemo(() => {
+    const current = turnChange()
+    if (!hasVisibleTurnChanges(current) || working() || turnInProgress()) return
+    return current
+  })
   const showReasoningSummaries = createMemo(() => props.showReasoningSummaries ?? true)
 
   const assistantCopyPartID = createMemo(() => {