Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item ID's for Shadow of the Erdtree #62

Open
Jammizzle opened this issue Jun 25, 2024 · 8 comments
Open

Item ID's for Shadow of the Erdtree #62

Jammizzle opened this issue Jun 25, 2024 · 8 comments

Comments

@Jammizzle
Copy link

No description provided.

@sciritai
Copy link

+1 on this. If @Ariescyn could post the method of discovering these items the community could also assist.

@vaalberith
Copy link

vaalberith commented Jul 5, 2024

Forked this project, patched ItemID savefile search and started adding some items from DLC to itemdata.py. Also removed that annoying popup after editing any item count, disabled long-timed savefile backup after each modification.

https://github.com/vaalberith/EldenRing-Save-Manager

All ItemID's:
https://github.com/veeenu/eldenring-practice-tool/blob/main/xtask/src/codegen/item_ids.yml

@sciritai
Copy link

Just want to +1 @vaalberith's fork and say thank you. Works perfectly and items are easier to work with as they're available in the category prompts, no need to custom item everything anymore. Better UX on adding items too as no longer need to click ok everytime you add something. I did have a timeout using bulk add(I presume it's bulk add for all characters?) but not sure I used it correctly. My save file has all characters filled and not all of them had DLC items, if that helps debugging.

Quick guide for anyone less tech savvy to run the fork:

  • Create github account
  • In Command Prompt run ssh-keygen to generate a key pair on windows, keys will be in user directory>.ssh folder
  • Add the id_rsa.pub file contents to github under Settings>SSH keys
  • Clone the fork using git. Install git here: https://git-scm.com/download/win
  • Install Python3: https://www.python.org/downloads/
  • As there's no built executable in the fork, in Command Prompt run "python3 SaveManager.py"

@SkyFoxDeity
Copy link

SkyFoxDeity commented Jul 28, 2024

Just want to +1 @vaalberith's fork and say thank you. Works perfectly and items are easier to work with as they're available in the category prompts, no need to custom item everything anymore. Better UX on adding items too as no longer need to click ok everytime you add something. I did have a timeout using bulk add(I presume it's bulk add for all characters?) but not sure I used it correctly. My save file has all characters filled and not all of them had DLC items, if that helps debugging.

Quick guide for anyone less tech savvy to run the fork:

  • Create github account
  • In Command Prompt run ssh-keygen to generate a key pair on windows, keys will be in user directory>.ssh folder
  • Add the id_rsa.pub file contents to github under Settings>SSH keys
  • Clone the fork using git. Install git here: https://git-scm.com/download/win
  • Install Python3: https://www.python.org/downloads/
  • As there's no built executable in the fork, in Command Prompt run "python3 SaveManager.py"

That final command isn't working for me. It keeps telling me that the command isn't recognized.

@sciritai
Copy link

@SkyFoxDeity Double check your python installation and ensure it is added to PATH: https://phoenixnap.com/kb/how-to-install-python-3-windows

@SkyFoxDeity
Copy link

@sciritai Everything appears to be in order. I looked over that step-by-step guide and everything it mentions I've already done. I've added Python to the PATH, installed the application as an administrator, verified that Python and PIP were installed, and even installed virtualenv, just in case. The python3 command still doesn't work.

@scottdraper8
Copy link

scottdraper8 commented Aug 1, 2024

@sciritai Everything appears to be in order. I looked over that step-by-step guide and everything it mentions I've already done. I've added Python to the PATH, installed the application as an administrator, verified that Python and PIP were installed, and even installed virtualenv, just in case. The python3 command still doesn't work.

If you could provide the error message you're seeing in Command Prompt then I'd be better able to help you out. However, my guess is that you were running into similar issues as I was. When attempting to run python3 SaveManager.py I received the following error messages:

C:\Users\Scott\Games\Elden Ring\EldenRing-Save-Manager-main\SaveManager.py:361: SyntaxWarning: invalid escape sequence '\,'
  if char in "~'{};:./\,:*?<>|-!@#$%^&()+":
C:\Users\Scott\Games\Elden Ring\EldenRing-Save-Manager-main\SaveManager.py:502: SyntaxWarning: invalid escape sequence '\,'
  if char in "~'{};:./\,:*?<>|-!@#$%^&()+":
C:\Users\Scott\Games\Elden Ring\EldenRing-Save-Manager-main\SaveManager.py:2369: SyntaxWarning: invalid escape sequence '\,'
  if char in "~'{};:./\,:*?<>|-!@#$%^&()+":
Traceback (most recent call last):
  File "C:\Users\Scott\Games\Elden Ring\EldenRing-Save-Manager-main\SaveManager.py", line 9, in <module>
    from PIL import Image, ImageTk
ModuleNotFoundError: No module named 'PIL'

To resolve this I did the following:

1. Update SaveManager.py

Fix three lines of code in SaveManager.py. Open up the file in a text editor and change lines 361, 502, and 2369 from:

if char in "~'{};:./\,:*?<>|-!@#$%^&()+":

to:

if char in "~'{};:./\\,:*?<>|-!@#$%^&()+":

This will ensure compatibility with Windows file pathing.

2. Install Pillow and requests

The SaveManger.py file will need two Python packages to run: Pillow and requests. In the Command Prompt install those packages by running this command:

pip3 install Pillow requests

3. Run the SaveManager

Now you'll be able to run the Save Manager by typing python3 SaveManager.py into the Command Prompt

@ArtoriasRex
Copy link

@SkyFoxDeity Maybe this helps

I just ran python SaveManager.py and it worked fine.

For other noobs like me who find this:

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants