From 6238b44a1455b407780dd614124bcfca57ca9f4d Mon Sep 17 00:00:00 2001 From: vargastat Date: Mon, 3 Feb 2025 17:19:32 +0100 Subject: [PATCH] fix: fix keyywords.ts for build --- .../data/stdTable/tests/tableCoreRowClassBuilder.test.ts | 2 -- src/pages/pegase/studies/KeywordsInput.tsx | 5 +++-- .../pegase/studies/studyDetails/StudyNavigationMenu.tsx | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/components/common/data/stdTable/tests/tableCoreRowClassBuilder.test.ts b/src/components/common/data/stdTable/tests/tableCoreRowClassBuilder.test.ts index e35b44e..6e984b9 100644 --- a/src/components/common/data/stdTable/tests/tableCoreRowClassBuilder.test.ts +++ b/src/components/common/data/stdTable/tests/tableCoreRowClassBuilder.test.ts @@ -12,8 +12,6 @@ import { tableCoreRowClassBuilder, } from '../tableCoreRowClassBuilder'; -const TEST_TR_CLASSES = 'bg-acc1-500 text-caption'; - describe('tableCoreRowClassBuilder function', () => { it('should have the expected striped classes', () => { expect(tableCoreRowClassBuilder(true).includes(STRIPED_CLASSES)).toBe(true); diff --git a/src/pages/pegase/studies/KeywordsInput.tsx b/src/pages/pegase/studies/KeywordsInput.tsx index 6dd4cca..ec733dd 100644 --- a/src/pages/pegase/studies/KeywordsInput.tsx +++ b/src/pages/pegase/studies/KeywordsInput.tsx @@ -33,7 +33,7 @@ const KeywordsInput: React.FC = ({ const [suggestedKeywords, setSuggestedKeywords] = useState([]); const handleKeywordChange = async (value: string) => { - if (value.length > maxNbCharacters) { + if (maxNbCharacters !== undefined && value.length > maxNbCharacters) { return; } setKeywordInput(value); @@ -90,6 +90,7 @@ const KeywordsInput: React.FC = ({ return input.length >= minNbCharacters && input.length <= maxNbCharacters; } } + return false; }; return ( @@ -103,7 +104,7 @@ const KeywordsInput: React.FC = ({ onChange={handleKeywordChange} placeHolder="Add a keyword" variant="outlined" - maxLength={maxNbCharacters ?? null} + maxLength={maxNbCharacters as number | undefined} /> {shouldAddKeywordButton(keywordInput) && ( diff --git a/src/pages/pegase/studies/studyDetails/StudyNavigationMenu.tsx b/src/pages/pegase/studies/studyDetails/StudyNavigationMenu.tsx index cc0b0d7..bb32a16 100644 --- a/src/pages/pegase/studies/studyDetails/StudyNavigationMenu.tsx +++ b/src/pages/pegase/studies/studyDetails/StudyNavigationMenu.tsx @@ -4,7 +4,7 @@ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ -import React, { ReactNode, useEffect, useState } from 'react'; +import { ReactNode, useEffect, useState } from 'react'; import { RdsTabItem } from 'rte-design-system-react'; import { StdIconId } from '@/shared/utils/common/mappings/iconMaps'; import LoadTab from '@/pages/pegase/studies/studyDetails/LoadTab';