From 7550fc17705ddddaa42534b2ca3e896d80e418f2 Mon Sep 17 00:00:00 2001
From: Guillaume PIERRE <guillaume.pierre@rte-france.com>
Date: Thu, 23 Jan 2025 17:03:24 +0100
Subject: [PATCH] Data for new modeler (4.1) : more fix due to review

---
 .../antares/solver/modeler/dataSeries/linearProblemData.h       | 2 +-
 .../include/antares/solver/modeler/dataSeries/timeSeriesSet.h   | 2 +-
 src/solver/modeler/dataSeries/linearProblemData.cpp             | 2 +-
 src/solver/modeler/dataSeries/timeSeriesSet.cpp                 | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/linearProblemData.h b/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/linearProblemData.h
index c0a11288f1..c8b8ea3587 100644
--- a/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/linearProblemData.h
+++ b/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/linearProblemData.h
@@ -39,7 +39,7 @@ class LinearProblemData: public Api::ILinearProblemData
                    const unsigned scenario,
                    const unsigned hour) override;
 
-    void addScenarioGroup(std::string groupId, std::pair<unsigned, unsigned> scenarioToRank);
+    void addScenarioGroup(const std::string& groupId, std::pair<unsigned, unsigned> scenarioToRank);
     void addDataSeries(std::unique_ptr<IDataSeries> dataSeries);
 
 private:
diff --git a/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/timeSeriesSet.h b/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/timeSeriesSet.h
index cf55917255..b868416a38 100644
--- a/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/timeSeriesSet.h
+++ b/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/timeSeriesSet.h
@@ -9,7 +9,7 @@ class TimeSeriesSet: public IDataSeries
 {
 public:
     explicit TimeSeriesSet(std::string name, unsigned height);
-    void add(std::vector<double> ts);
+    void add(const std::vector<double>& ts);
     double getData(unsigned rank, unsigned hour) override;
 
 private:
diff --git a/src/solver/modeler/dataSeries/linearProblemData.cpp b/src/solver/modeler/dataSeries/linearProblemData.cpp
index e0b77187ab..574b8cd550 100644
--- a/src/solver/modeler/dataSeries/linearProblemData.cpp
+++ b/src/solver/modeler/dataSeries/linearProblemData.cpp
@@ -24,7 +24,7 @@
 namespace Antares::Solver::Modeler::DataSeries
 {
 
-void LinearProblemData::addScenarioGroup(std::string groupId,
+void LinearProblemData::addScenarioGroup(const std::string& groupId,
                                          std::pair<unsigned, unsigned> scenarioToRank)
 {
     groupRepository_.addPairScenarioRankToGroup(groupId, scenarioToRank);
diff --git a/src/solver/modeler/dataSeries/timeSeriesSet.cpp b/src/solver/modeler/dataSeries/timeSeriesSet.cpp
index b4ad507025..2cefe5710e 100644
--- a/src/solver/modeler/dataSeries/timeSeriesSet.cpp
+++ b/src/solver/modeler/dataSeries/timeSeriesSet.cpp
@@ -13,7 +13,7 @@ TimeSeriesSet::TimeSeriesSet(std::string name, unsigned int height):
 {
 }
 
-void TimeSeriesSet::add(std::vector<double> ts)
+void TimeSeriesSet::add(const std::vector<double>& ts)
 {
     if (ts.size() != height_)
     {