From 86fe2ed30f3c0494306c38713a6f96e856eb003a Mon Sep 17 00:00:00 2001
From: hatim dinia <diniahatim@gmail.com>
Date: Wed, 29 Nov 2023 15:28:38 +0100
Subject: [PATCH] feat(ui-model): add validation rules for thermal renewable
 and storage forms

---
 .../Modelization/Areas/Renewables/Fields.tsx  | 12 +++
 .../Modelization/Areas/Storages/Fields.tsx    | 38 ++++++++
 .../Modelization/Areas/Thermal/Fields.tsx     | 86 +++++++++++++++++++
 3 files changed, 136 insertions(+)

diff --git a/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Renewables/Fields.tsx b/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Renewables/Fields.tsx
index 6f60db0fbb..1e49ed3f97 100644
--- a/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Renewables/Fields.tsx
+++ b/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Renewables/Fields.tsx
@@ -61,11 +61,23 @@ function Fields() {
           label={t("study.modelization.clusters.unitcount")}
           name="unitCount"
           control={control}
+          rules={{
+            min: {
+              value: 1,
+              message: t("form.field.minValue", { 0: 1 }),
+            },
+          }}
         />
         <NumberFE
           label={t("study.modelization.clusters.nominalCapacity")}
           name="nominalCapacity"
           control={control}
+          rules={{
+            min: {
+              value: 0,
+              message: t("form.field.minValue", { 0: 0 }),
+            },
+          }}
         />
       </Fieldset>
     </>
diff --git a/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Storages/Fields.tsx b/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Storages/Fields.tsx
index 3008f21406..0e04b378a0 100644
--- a/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Storages/Fields.tsx
+++ b/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Storages/Fields.tsx
@@ -43,6 +43,12 @@ function Fields() {
             label={t("study.modelization.storages.injectionNominalCapacity")}
             name="injectionNominalCapacity"
             control={control}
+            rules={{
+              min: {
+                value: 0,
+                message: t("form.field.minValue", { 0: 0 }),
+              },
+            }}
           />
         </Box>
       </Tooltip>
@@ -56,6 +62,12 @@ function Fields() {
             label={t("study.modelization.storages.withdrawalNominalCapacity")}
             name="withdrawalNominalCapacity"
             control={control}
+            rules={{
+              min: {
+                value: 0,
+                message: t("form.field.minValue", { 0: 0 }),
+              },
+            }}
           />
         </Box>
       </Tooltip>
@@ -69,6 +81,12 @@ function Fields() {
             label={t("study.modelization.storages.reservoirCapacity")}
             name="reservoirCapacity"
             control={control}
+            rules={{
+              min: {
+                value: 0,
+                message: t("form.field.minValue", { 0: 0 }),
+              },
+            }}
           />
         </Box>
       </Tooltip>
@@ -77,11 +95,31 @@ function Fields() {
         label={t("study.modelization.storages.efficiency")}
         name="efficiency"
         control={control}
+        rules={{
+          min: {
+            value: 0,
+            message: t("form.field.minValue", { 0: 0 }),
+          },
+          max: {
+            value: 1,
+            message: t("form.field.maxValue", { 0: 1 }),
+          },
+        }}
       />
       <NumberFE
         label={t("study.modelization.storages.initialLevel")}
         name="initialLevel"
         control={control}
+        rules={{
+          min: {
+            value: 0,
+            message: t("form.field.minValue", { 0: 0 }),
+          },
+          max: {
+            value: 1,
+            message: t("form.field.maxValue", { 0: 1 }),
+          },
+        }}
       />
       <SwitchFE
         label={t("study.modelization.storages.initialLevelOptim")}
diff --git a/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Thermal/Fields.tsx b/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Thermal/Fields.tsx
index 98a986bf4c..eb72566de8 100644
--- a/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Thermal/Fields.tsx
+++ b/webapp/src/components/App/Singlestudy/explore/Modelization/Areas/Thermal/Fields.tsx
@@ -67,11 +67,23 @@ function Fields() {
           label={t("study.modelization.clusters.unitcount")}
           name="unitCount"
           control={control}
+          rules={{
+            min: {
+              value: 1,
+              message: t("form.field.minValue", { 0: 1 }),
+            },
+          }}
         />
         <NumberFE
           label={t("study.modelization.clusters.nominalCapacity")}
           name="nominalCapacity"
           control={control}
+          rules={{
+            min: {
+              value: 0,
+              message: t("form.field.minValue", { 0: 0 }),
+            },
+          }}
         />
         <NumberFE
           label={t("study.modelization.clusters.minStablePower")}
@@ -82,16 +94,46 @@ function Fields() {
           label={t("study.modelization.clusters.spinning")}
           name="spinning"
           control={control}
+          rules={{
+            min: {
+              value: 0,
+              message: t("form.field.minValue", { 0: 0 }),
+            },
+            max: {
+              value: 100,
+              message: t("form.field.maxValue", { 0: 100 }),
+            },
+          }}
         />
         <NumberFE
           label={t("study.modelization.clusters.minUpTime")}
           name="minUpTime"
           control={control}
+          rules={{
+            min: {
+              value: 1,
+              message: t("form.field.minValue", { 0: 1 }),
+            },
+            max: {
+              value: 168,
+              message: t("form.field.maxValue", { 0: 168 }),
+            },
+          }}
         />
         <NumberFE
           label={t("study.modelization.clusters.minDownTime")}
           name="minDownTime"
           control={control}
+          rules={{
+            min: {
+              value: 1,
+              message: t("form.field.minValue", { 0: 1 }),
+            },
+            max: {
+              value: 168,
+              message: t("form.field.maxValue", { 0: 168 }),
+            },
+          }}
         />
       </Fieldset>
       <Fieldset legend={t("study.modelization.clusters.operatingCosts")}>
@@ -99,21 +141,45 @@ function Fields() {
           label={t("study.modelization.clusters.marginalCost")}
           name="marginalCost"
           control={control}
+          rules={{
+            min: {
+              value: 0,
+              message: t("form.field.minValue", { 0: 0 }),
+            },
+          }}
         />
         <NumberFE
           label={t("study.modelization.clusters.fixedCost")}
           name="fixedCost"
           control={control}
+          rules={{
+            min: {
+              value: 0,
+              message: t("form.field.minValue", { 0: 0 }),
+            },
+          }}
         />
         <NumberFE
           label={t("study.modelization.clusters.startupCost")}
           name="startupCost"
           control={control}
+          rules={{
+            min: {
+              value: 0,
+              message: t("form.field.minValue", { 0: 0 }),
+            },
+          }}
         />
         <NumberFE
           label={t("study.modelization.clusters.marketBidCost")}
           name="marketBidCost"
           control={control}
+          rules={{
+            min: {
+              value: 0,
+              message: t("form.field.minValue", { 0: 0 }),
+            },
+          }}
         />
         <NumberFE
           label={t("study.modelization.clusters.spreadCost")}
@@ -154,11 +220,31 @@ function Fields() {
           label={t("study.modelization.clusters.volatilityForced")}
           name="volatilityForced"
           control={control}
+          rules={{
+            min: {
+              value: 0,
+              message: t("form.field.minValue", { 0: 0 }),
+            },
+            max: {
+              value: 1,
+              message: t("form.field.maxValue", { 0: 1 }),
+            },
+          }}
         />
         <NumberFE
           label={t("study.modelization.clusters.volatilityPlanned")}
           name="volatilityPlanned"
           control={control}
+          rules={{
+            min: {
+              value: 0,
+              message: t("form.field.minValue", { 0: 0 }),
+            },
+            max: {
+              value: 1,
+              message: t("form.field.maxValue", { 0: 1 }),
+            },
+          }}
         />
         <SelectFE
           label={t("study.modelization.clusters.lawForced")}