Patch iterator walking past end (hanickadot#140)

* Patch iterator walking past end

Resolves hanickadot#139

* Update evaluation.hpp

reformat and spell it a bit differently

Co-authored-by: Hana Dusíková <[email protected]>

Author: Andersama

include/ctre/evaluation.hpp

@@ -139,9 +139,10 @@ template <typename Iterator> struct string_match_result {
 };
 
 template <typename CharT, typename Iterator, typename EndIterator> constexpr CTRE_FORCE_INLINE bool compare_character(CharT c, Iterator & it, const EndIterator & end) {
-	bool same = ((it != end) && (*it == c));
-	++it;
-	return same;
+	if (it != end) {
+		return *it++ == c;
+	}
+	return false;
 }
 
 template <auto... String, size_t... Idx, typename Iterator, typename EndIterator> constexpr CTRE_FORCE_INLINE string_match_result<Iterator> evaluate_match_string(Iterator current, [[maybe_unused]] const EndIterator end, std::index_sequence<Idx...>) noexcept {