Skip to content

ChannelSpec fields #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
14 of 16 tasks
elpiel opened this issue May 22, 2019 · 3 comments
Closed
14 of 16 tasks

ChannelSpec fields #24

elpiel opened this issue May 22, 2019 · 3 comments
Milestone
sentry-v0.2.0

Comments

@elpiel
Copy link
Member

elpiel commented May 22, 2019 •
edited
Loading

Add fields:

Postgres implementation:
@elpiel elpiel added this to the 0.2.0 milestone May 22, 2019
This was referenced May 22, 2019
Closed
Closed
Closed
Merged
Closed
elpiel added a commit that referenced this issue May 29, 2019
@elpiel
Issue #24 ChannelSpec (#37)
eeb35f8 
* domain - add dummy structs:
- AdUnit
- EventSubmission
- TargetingTag

* util - serde - ts_milliseconds_option - impl ser/deser for `Option<DateTime<Utc>>`

* domain - ChannelSpec - adding all the fields in almost ready state:
- domain - ValidatorDesc - rename `id` to `addr`
- domain - ChannelSpec - add all the optional fields & optional DateTime for `active_from`
- domain - channel - fixtures - update `get_channel_spec` fixture with **dummy** data for now

* util - test - take_one
- Cargo.toml - add `rand` to `dev-dependencies`

* - domain - channel - fixtures - get_channel_spec - add most of the fake data generated from `Faker`

* - domain - channel - fixtures - get_channel_spec - small improvements
elpiel added a commit that referenced this issue May 29, 2019
@elpiel
Revert "Issue #24 ChannelSpec (#37)"
e890881 
This reverts commit eeb35f8.
@elpiel
Copy link
Member Author

elpiel commented May 31, 2019

@Ivshti is minTargetingScore also from 0 to 100 like the TargetingTag score?

@Ivshti
Copy link
Member

Ivshti commented Jun 5, 2019

no; it's f64

@elpiel elpiel mentioned this issue Jun 5, 2019
Merged
8 tasks
@elpiel
Copy link
Member Author

elpiel commented Aug 30, 2019

No need for this anymore

@elpiel elpiel closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sentry-v0.2.0
Development

No branches or pull requests
2 participants
@Ivshti @elpiel