-
Notifications
You must be signed in to change notification settings - Fork 10
ChannelSpec fields #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
This was referenced May 22, 2019
Closed
Merged
Closed
elpiel
added a commit
that referenced
this issue
May 29, 2019
* domain - add dummy structs: - AdUnit - EventSubmission - TargetingTag * util - serde - ts_milliseconds_option - impl ser/deser for `Option<DateTime<Utc>>` * domain - ChannelSpec - adding all the fields in almost ready state: - domain - ValidatorDesc - rename `id` to `addr` - domain - ChannelSpec - add all the optional fields & optional DateTime for `active_from` - domain - channel - fixtures - update `get_channel_spec` fixture with **dummy** data for now * util - test - take_one - Cargo.toml - add `rand` to `dev-dependencies` * - domain - channel - fixtures - get_channel_spec - add most of the fake data generated from `Faker` * - domain - channel - fixtures - get_channel_spec - small improvements
@Ivshti is |
no; it's f64 |
No need for this anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add fields:
title
added in Issue #24 ChannelSpec #37adUnits
added in Issue #24 ChannelSpec #37targeting
added in Issue #24 ChannelSpec #37validators
( should be an array of 2 validators - leader & follower) Dummy adapter #53withdrawPeriodStart
added in Issue #24 ChannelSpec #37minPerImpression
added in Issue #24 ChannelSpec #37maxPerImpression
added in Issue #24 ChannelSpec #37minTargetingScore
added in Issue #24 ChannelSpec #37eventSubmission
added in Issue #24 ChannelSpec #37nonce
added in Issue #24 ChannelSpec #37created
added in Issue #24 ChannelSpec #37activeFrom
added in Issue #24 ChannelSpec #37update fixtures - still requires fixtures for AdUnit, EventSubmission and etc.
Implement the
withdraw_period_start
restriction from the channel validation in the JS implementaiton in the ChannelSpec deserialization (probably wrap the BigNum in a tuple struct and validate it there)Postgres implementation:
validators
should be in the blob as an array PR Domain crate #42The text was updated successfully, but these errors were encountered: