added campaign_find_limt to config, fixed documentation and match statement

Author: simzzz

docs/config/dev.toml

@@ -2,6 +2,7 @@
 max_channels = 512
 
 channels_find_limit = 200
+campaigns_find_limit = 200
 wait_time = 500
 
 # V4 Deprecated

docs/config/prod.toml

@@ -2,6 +2,8 @@
 max_channels = 512
 
 channels_find_limit = 512
+campaigns_find_limit = 512
+
 wait_time = 40000
 
 # V4 Deprecated

primitives/src/config.rs

@@ -25,6 +25,7 @@ pub struct TokenInfo {
 pub struct Config {
     pub max_channels: u32,
     pub channels_find_limit: u32,
+    pub campaigns_find_limit: u32,
     pub wait_time: u32,
     #[deprecated = "redundant V4 value. No aggregates are needed for V5"]
     pub aggr_throttle: u32,

primitives/src/sentry.rs

@@ -352,7 +352,7 @@ pub mod campaign {
         /// filters the campaigns containing a specific validator if provided
         pub validator: Option<ValidatorId>,
         /// filters the campaigns where the provided validator is a leader if true
-        /// or if a validator isn't provided but an Auth.uid is provided (i.e. there is a auth header with token)
+        /// if no validator is provided, but is_leader is true, it uses Auth to obtain a validator
         pub is_leader: Option<bool>,
     }
 }

sentry/src/db/campaign.rs

@@ -586,7 +586,7 @@ mod test {
     }
 
     // Campaigns are sorted in ascending order when retrieved
-    // Therefore every campaign in the
+    // Therefore the last campaign inserted will come up first in results
     #[tokio::test]
     async fn it_lists_campaigns_properly() {
         let database = DATABASE_POOL.get().await.expect("Should get a DB pool");

sentry/src/routes/campaign.rs

@@ -225,13 +225,13 @@ pub async fn campaign_list<A: Adapter>(
     let mut query =
         serde_urlencoded::from_str::<CampaignListQuery>(req.uri().query().unwrap_or(""))?;
 
-    query.validator = match (query.validator, req.extensions().get::<Auth>()) {
-        (Some(validator), _) => Some(validator),
-        (None, Some(session)) => Some(session.uid),
-        (None, None) => None,
+    query.validator = match (query.validator, query.is_leader, req.extensions().get::<Auth>()) {
+        (None, Some(true), Some(session)) => Some(session.uid), // only case where session.uid is used
+        (Some(validator), _, _) => Some(validator), // for all cases with a validator passed
+        _ => None, // default, no filtration by validator
     };
 
-    let limit = 100; // TODO: Use a value from config
+    let limit = app.config.campaigns_find_limit;
     let skip = query
         .page
         .checked_mul(limit.into())