-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose lprofGetLoadModuleSignature
#26
Comments
Sure, I think it's reasonable to expose the module signature. Could you also explain the workflow that requires matching LLVM's file names? I personally just dump everything to a single file and then pass it to grcov. |
I'm currently working on adding So no, my workflow doesn't not require the module signature, but it would be great to have and the tradeoff seems quite small to me. |
If you don't actually care about the name, just that it's unique, then there are better ways of doing this than using |
Indeed, I'm aware!
But no, there is no specific use-case that I anticipate that will require files to be named exactly the same. |
I think it's still fine to expose this from minicov. |
It would be very useful if we could mimic the filenames generated by LLVM with
minicov
. While we can't really includeInstrProfilingFile.c
, at leastlprofGetLoadModuleSignature
is already there. With that the rest could be done independently ofminicov
.If this is in scope, I would be happy to make the PR myself!
The text was updated successfully, but these errors were encountered: