This repository was archived by the owner on Jan 7, 2021. It is now read-only.
Report issues with no direct line in the diff view #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2017
|
Why isn't this in master yet :) ? |
Contributor
Author
|
Because none of the users confirmed, that this is what they want :-) |
|
Then I will confirm - that this would be nice :) |
Contributor
Author
|
Well, you should confirm that the implementation in this PR is sufficient. |
|
I read through the code, and it seems good 😄 The only comment I have is if it should be a setting, and not forced on all users - maybe? But not sure. |
Contributor
Author
|
Please confirm the implementation. |
|
I am sorry I don't understand - is there a button or so for that? |
Contributor
Author
|
No, you would have to get the source for this PR, build it, install it in sonarqube, run an analysis, see if it behaves as you expect and then possibly confirm the implementation. |
|
ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may happen if the issue is reported on a line, that is not directly
involved in the PR
Closes #135 #137