Skip to content
This repository was archived by the owner on Jan 7, 2021. It is now read-only.

Add comment to stash when issue does not belong to diff view #137

Closed
wants to merge 1 commit into from
Closed

Add comment to stash when issue does not belong to diff view #137

wants to merge 1 commit into from

Conversation

@mdanielak
Copy link

@mdanielak mdanielak commented Jun 28, 2017

Addressing issue 135

@mdanielak mdanielak mentioned this pull request Jun 28, 2017
Open
@KanwarGill
Copy link

KanwarGill commented Sep 6, 2017 •
edited
Loading

Any updates on this? It has conflicts @mdanielak

@t-8ch
Copy link
Contributor

t-8ch commented Nov 1, 2017

Hi @mdanielak ,

unfortunately there are some issues with this aproach:

  • The plugin will now try to add a file-wide comment for all comments that can not be posted on a specific file. This will break if the issue does not belong to a file in the diff.
  • This aproach breaks the detection whether a comment has been already submitted, resulting in duplicated comments

t-8ch added a commit that referenced this pull request Nov 1, 2017
@t-8ch
report issues with no direct line in the diff view
7c80c98 
this may happen if the issue is reported on a line, that is not directly
involved in the PR

Closes #135 #137
@t-8ch t-8ch mentioned this pull request Nov 1, 2017
Open
@t-8ch
Copy link
Contributor

t-8ch commented Nov 1, 2017

This is now superseeded by #161.

@t-8ch t-8ch closed this Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdanielak @KanwarGill @t-8ch