-
Notifications
You must be signed in to change notification settings - Fork 0
Test email serive get status #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1. Send command added an optional parameter "waitUntil". 2. Added command to get email request status
| ++++++ | ||
| * Adding new parameter waituntil to Email communication send mail. | ||
| * Adding new command get send status to Email communication. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎
+* Adding new parameter `waituntil` to Email communication send mail.
+* Adding new command `get send status` to Email communication.| - name: Get status of an email | ||
| text: |- | ||
| az communication email status get --operation-id "01234567-89ab-cdef-0123-012345678901" --connection-string "endpoint=XXXXXXXXXXXXXXXX;accesskey=XXXXXXXXXXXXXXXXXXXXXX" | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎
- short-summary: "Get status of an email previously sent."
Replace "an" with "a" to correct the grammar:
- Change to: "Get status of a previously sent email."
| with self.command_group('communication email', client_factory=cf_communication_email) as g: | ||
| g.communication_custom_command('send', 'communication_email_send', email_arguments) | ||
| with self.command_group('communication email', is_preview=True) as g: | ||
| g.communication_custom_command('status get', 'communication_email_get_status', email_arguments) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎
+ with self.command_group('communication email', is_preview=True) as g:
+ g.communication_custom_command('status get', 'communication_email_get_status', email_arguments)Refinement:
Combine both command groups into a single with statement to avoid redundancy:
with self.command_group('communication email', client_factory=cf_communication_email, is_preview=True) as g:
g.communication_custom_command('send', 'communication_email_send', email_arguments)
g.communication_custom_command('status get', 'communication_email_get_status', email_arguments)| @@ -1,7 +1,12 @@ | |||
| .. :changelog: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎
PR Summary:
- Added a new parameter
waitUntilto the Email communicationsendmail command. - Introduced a new command
get send statusto obtain the status of previously sent emails. - Implemented a function to prepare attachments for email sending.
- Updated the email send functionality to support operation ID and wait-until condition.
- Added helper functions to parse connection strings and create signature headers.
- Modified version from 1.9.3 to 1.10.0.
7059eb5 to
3ab770e
Compare
* add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * update readme and version release notes (#12) * remove extension specific pester tests --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bragi92 <[email protected]> Co-authored-by: Long Wan <[email protected]>
* add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Add k8s-extension troubleshoot phase 1: Infrastructure setup. (#11) * [k8s-extension] Update extension CLI to v1.7.0 (#13) * remove redundant test files --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bragi92 <[email protected]> Co-authored-by: Long Wan <[email protected]> Co-authored-by: Andres Borja <[email protected]>
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.