Skip to content

Commit 43c4fa2

Browse files
authored
Merge pull request #1806 from AllenInstitute/bugfix/deprecated-scipy-rotation-as-dcm
updates Rotation.as_dcm to as_matrix
2 parents 9f64b72 + 0609647 commit 43c4fa2

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
# Change Log
22
All notable changes to this project will be documented in this file.
33

4+
## [2.4.1] = 2021-01-04
5+
- update deprecated call to scipy.spatial.transform.Rotation.as_dcm() to .as_matrix()
6+
47
## [2.4.0] = 2020-12-21
58
- When running raster_plot on a spike_times dataframe, the spike times from each unit are plotted twice. (thank you @dgmurx)
69
- improvements and fixes to behavior ophys NWB files.

allensdk/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838

3939

40-
__version__ = '2.4.0'
40+
__version__ = '2.4.1'
4141

4242

4343
try:

allensdk/test/brain_observatory/gaze_mapping/test_gaze_mapping.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def rig_component_fixture(request):
5050
], indirect=['rig_component_fixture'])
5151
def test_generate_self_to_eye_frame_xform(rig_component_fixture, expected):
5252
obtained = rig_component_fixture.generate_self_to_eye_frame_xform()
53-
assert np.allclose(obtained.as_dcm(), expected)
53+
assert np.allclose(obtained.as_matrix(), expected)
5454

5555

5656
# ======== GazeMapper tests ========
@@ -341,4 +341,4 @@ def test_project_to_plane(function_inputs, expected):
341341
])
342342
def test_generate_object_rotation_xform(function_inputs, expected):
343343
obtained = gm.generate_object_rotation_xform(**function_inputs)
344-
assert np.allclose(obtained.as_dcm(), expected)
344+
assert np.allclose(obtained.as_matrix(), expected)

0 commit comments

Comments
 (0)