Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: [Resolver] The review doesn't appear to see the code changes #5502

Closed
1 task done
enyst opened this issue Dec 10, 2024 · 2 comments · Fixed by #5950
Closed
1 task done

[Bug]: [Resolver] The review doesn't appear to see the code changes #5502

enyst opened this issue Dec 10, 2024 · 2 comments · Fixed by #5950
Assignees
@neubig
Labels
bug Something isn't working resolver Related to OpenHands Resolver

Comments

@enyst
Copy link
Collaborator

enyst commented Dec 10, 2024 •
edited
Loading

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

Please see:
#5498 (comment)

"The feedback specifically asked to check if "bedrock" is in self.config.model, similar to other examples in llm.py, but we don't see the actual code implementation of this check."

Yes we do. It is in the new commit, and it's a change to the same line of the comment or the very next line. The review part of the resolver doesn't seem to have received that information?

Log: https://github.com/All-Hands-AI/OpenHands/actions/runs/12250048486/job/34172354640#step:10:885

OpenHands Installation

Other

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response
@enyst enyst added the bug Something isn't working label Dec 10, 2024
@enyst enyst changed the title [Bug]: [Resolver] The "review" doesn't appear to see the code changes [Bug]: [Resolver] The review doesn't appear to see the code changes Dec 10, 2024
@enyst
Copy link
Collaborator Author

enyst commented Dec 12, 2024

Also here, strange message from the review step:

Unable to verify if feedback was successfully addressed since the original PR content and actual code changes are not visible. While the AI agent claims to have added unit tests and fixed linting issues, without seeing the implemented changes and tests, I cannot confirm if they properly test the functionality mentioned in PR #5550 or if they meet the requirements. To properly evaluate this, I would need to see both the original PR content and the actual code/test changes made.

https://github.com/All-Hands-AI/OpenHands/actions/runs/12294156882/job/34308359214#step:10:21504

@mamoodi mamoodi added the resolver Related to OpenHands Resolver label Dec 15, 2024
@xingyaoww
Copy link
Collaborator

Here's another similar issue:

#5700 (comment)

@enyst enyst mentioned this issue Dec 29, 2024
Closed
1 task
@neubig neubig self-assigned this Jan 1, 2025
@neubig neubig mentioned this issue Jan 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neubig neubig

Labels
bug Something isn't working resolver Related to OpenHands Resolver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add git patch info to guess_success prompt All-Hands-AI/OpenHands
4 participants
@neubig @enyst @xingyaoww @mamoodi