Merge pull request #1458 from Alfresco/bugfix/dev-mkinas-MNT-23143-allow-discoveryService-withCredentials

[MNT-23143] withCredentials reflected in isBpmLoggedIn

Author: MichalKinas

src/alfrescoApi.ts

@@ -452,9 +452,9 @@ export class AlfrescoApi implements Emitter, AlfrescoApiType {
             if (this.isBpmConfiguration()) {
                 return this.processAuth.isLoggedIn();
             } else if (this.isEcmConfiguration()) {
-                return this.contentAuth.isLoggedIn();
+                return this.config.withCredentials ? true : this.contentAuth.isLoggedIn();
             } else if (this.isEcmBpmConfiguration()) {
-                return this.contentAuth.isLoggedIn() && this.processAuth.isLoggedIn();
+                return this.config.withCredentials ? true : (this.contentAuth.isLoggedIn() && this.processAuth.isLoggedIn());
             } else {
                 return false;
             }
@@ -477,7 +477,7 @@ export class AlfrescoApi implements Emitter, AlfrescoApiType {
             if (this.isOauthConfiguration()) {
                 return this.oauth2Auth.isLoggedIn();
             } else {
-                return this.contentAuth.isLoggedIn();
+                return this.config.withCredentials ? true : this.contentAuth.isLoggedIn();
             }
         }
         return false;

test/alfrescoApi.spec.ts

@@ -96,6 +96,39 @@ describe('Basic configuration test', () => {
             expect(alfrescoJsApi.processClient.isWithCredentials()).equal(true);
         });
 
+        it('should withCredentials true parameter with hostEcm should be reflected in isEcmLoggedIn', () => {
+            const hostEcm = 'http://127.0.0.1:8080';
+            const alfrescoJsApi = new AlfrescoApi({
+                hostEcm,
+                provider: 'ECM',
+                withCredentials: true
+            } as AlfrescoApiConfig);
+
+            expect(alfrescoJsApi.isEcmLoggedIn()).equal(true);
+        });
+
+        it('should withCredentials true parameter with hostEcm should be reflected in isLoggedIn', () => {
+            const hostEcm = 'http://127.0.0.1:8080';
+            const alfrescoJsApi = new AlfrescoApi({
+                hostEcm,
+                provider: 'ECM',
+                withCredentials: true
+            } as AlfrescoApiConfig);
+
+            expect(alfrescoJsApi.isLoggedIn()).equal(true);
+        });
+
+        it('should withCredentials true parameter with ALL provider should be reflected in isLoggedIn', () => {
+            const hostEcm = 'http://127.0.0.1:8080';
+            const alfrescoJsApi = new AlfrescoApi({
+                hostEcm,
+                provider: 'ALL',
+                withCredentials: true
+            } as AlfrescoApiConfig);
+
+            expect(alfrescoJsApi.isLoggedIn()).equal(true);
+        });
+
         it('should withCredentials false parameter should be reflected in the clients', () => {
             const config = {
                 hostEcm: 'http://testServer.com:1616',