[ADF-4075] TaskFormsApi - change getRestFieldValues return format (#392)

* change getRestFieldValues reponse type

* change deserialize return type if response it is array type

* fix unit test

Author: SilviuCPopa

src/alfrescoApi.ts

@@ -248,7 +248,7 @@ export class AlfrescoApi {
 
             oauth2AuthPromise.then((accessToken) => {
                 this.config.accessToken = accessToken;
-            }, () => {
+            },                     () => {
                 console.log('login OAUTH error');
             });
 
@@ -261,7 +261,7 @@ export class AlfrescoApi {
 
                 processPromise.then((ticketBpm) => {
                     this.config.ticketBpm = ticketBpm;
-                }, () => {
+                },                  () => {
                     console.log('login BPM error');
                 });
 
@@ -273,7 +273,7 @@ export class AlfrescoApi {
                     this.setAuthenticationClientECMBPM(this.contentAuth.getAuthentication(), null);
 
                     this.config.ticketEcm = ticketEcm;
-                }, () => {
+                },                  () => {
                     console.log('login ECM error');
                 });
 
@@ -366,7 +366,7 @@ export class AlfrescoApi {
                 let contentPromise = this.contentAuth.logout();
                 contentPromise.then(() => {
                     this.config.ticket = undefined;
-                }, () => {
+                },                  () => {
                 });
 
                 return contentPromise;

src/alfrescoApiClient.ts

@@ -282,7 +282,13 @@ export class AlfrescoApiClient {
         }
 
         if (returnType) {
-            data = new returnType(data);
+            if (Array.isArray(data)) {
+                data = data.map( (element) => {
+                    return new returnType(element);
+                });
+            } else {
+                data = new returnType(data);
+            }
         }
 
         return data;

src/api-legacy/activiti-rest-api/src/api/ProcessApi.ts

@@ -83,11 +83,11 @@ export class ProcessApi {
         return this.processInstancesApi.getProcessAuditPdf(processInstanceId);
     }
 
-    getRestFieldValues(processDefinitionId: string, field: string): Promise<FormValueRepresentation> {
+    getRestFieldValues(processDefinitionId: string, field: string): Promise<FormValueRepresentation []> {
         return this.processDefinitionsApi.getRestFieldValues(processDefinitionId, field);
     }
 
-    getRestTableFieldValues(processDefinitionId: string, field: string, column: string): Promise<FormValueRepresentation> {
+    getRestTableFieldValues(processDefinitionId: string, field: string, column: string): Promise<FormValueRepresentation []> {
         return this.processDefinitionsApi.getRestTableFieldValues(processDefinitionId, field, column);
     }
 

src/api-legacy/activiti-rest-api/src/api/ProcessDefinitionsFormApi.ts

@@ -35,11 +35,11 @@ export class ProcessDefinitionsFormApi {
         return this.processDefinitionsApi.getProcessDefinitionStartForm(processDefinitionId);
     }
 
-    getRestFieldValues(processDefinitionId: string, field: string): Promise<FormValueRepresentation> {
+    getRestFieldValues(processDefinitionId: string, field: string): Promise<FormValueRepresentation []> {
         return this.processDefinitionsApi.getRestFieldValues(processDefinitionId, field);
     }
 
-    getRestTableFieldValues(processDefinitionId: string, field: string, column: string): Promise<FormValueRepresentation> {
+    getRestTableFieldValues(processDefinitionId: string, field: string, column: string): Promise<FormValueRepresentation []> {
         return this.processDefinitionsApi.getRestTableFieldValues(processDefinitionId, field, column);
     }
 }

src/api/activiti-rest-api/api/processDefinitions.api.ts

@@ -365,9 +365,9 @@ export class ProcessDefinitionsApi extends BaseApi {
      *
      * @param processDefinitionId processDefinitionId
      *
-     * @return Promise<FormValueRepresentation>
+     * @return Promise<FormValueRepresentation[]>
      */
-    getRestFieldValues(processDefinitionId: string, field: string): Promise<FormValueRepresentation> {
+    getRestFieldValues(processDefinitionId: string, field: string): Promise<FormValueRepresentation []> {
 
         let postBody = null;
 
@@ -395,9 +395,9 @@ export class ProcessDefinitionsApi extends BaseApi {
      *
      * @param processDefinitionId processDefinitionId
      *
-     * @return Promise<FormValueRepresentation>
+     * @return Promise<FormValueRepresentation []>
      */
-    getRestTableFieldValues(processDefinitionId: string, field: string, column: string): Promise<FormValueRepresentation> {
+    getRestTableFieldValues(processDefinitionId: string, field: string, column: string): Promise<FormValueRepresentation []> {
 
         let postBody = null;
 

src/api/activiti-rest-api/api/taskForms.api.ts

@@ -161,9 +161,9 @@ export class TaskFormsApi extends BaseApi {
         *
         * @param taskId taskId
         * @param field field
-        * @return Promise<FormValueRepresentation>
+        * @return Promise<FormValueRepresentation []>
         */
-    getRestFieldValues(taskId: string, field: string): Promise<FormValueRepresentation> {
+    getRestFieldValues(taskId: string, field: string): Promise<FormValueRepresentation []> {
 
         let postBody = null;
 

test/alfrescoApiClient.spec.ts

@@ -1,6 +1,6 @@
 /*global describe, it */
 
-import { AlfrescoApiClient } from  '../index';
+import { AlfrescoApiClient, FormValueRepresentation } from  '../index';
 import { DateAlfresco } from  '../index';
 let chai = require('chai');
 
@@ -77,4 +77,28 @@ describe('Alfresco Core API Client', function () {
 
     });
 
+    describe('Deserializes', function () {
+
+        it('should the deserializer return an array of object when the response is an array', function() {
+            const client = new AlfrescoApiClient();
+            const data = {
+                body: [
+                    {
+                        id: "1",
+                        name: "test1"
+                    },
+                    {
+                        id: "2",
+                        name: "test2"
+                    }
+                ]
+            };
+            const result = client.deserialize(data, FormValueRepresentation);
+            const isArray = Array.isArray(result);
+            const isObject = (result[0] instanceof (FormValueRepresentation));
+            expect(isArray).to.equal(true);
+            expect(isObject).to.equal(true);
+        })
+    });
+
 });