This repository was archived by the owner on Sep 13, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 153
Use getMenu instead of getApplicationMenu #242
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Problem Description
Code uses Menu.getApplicationMenu() but should use mainWindow.getMenu()
ipcMain.handle('request-application-menu', async () => JSON.parse(JSON.stringify(
Menu.getApplicationMenu(),
(key: string, value: any) => (key !== 'commandsMap' && key !== 'menu') ? value : undefined)
))
Expected Behavior
When setting a menu with mainWindow.setMenu(), this package no longer finds the menu items.
So my code has to use Menu.setApplicationMenu() for this package to work. The problem is that this sets the same menu to all windows, including the dev tools.
This is probably a big source for this package not working for other users since there is no feedback at all why the menu is empty.
"electron": "25.8.2",
"custom-electron-titlebar": "^4.2.7",
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request