Merge pull request #3397 from AlchemyCMS/locale-select

Add Alchemy::Admin::LocaleSelect component

Author: tvdeyen

app/components/alchemy/admin/locale_select.rb

@@ -0,0 +1,38 @@
+module Alchemy
+  module Admin
+    # Renders a locale select tag for switching the backend locale.
+    class LocaleSelect < ViewComponent::Base
+      attr_reader :name
+
+      def initialize(name = :change_locale)
+        @name = name
+      end
+
+      def call
+        select_tag(
+          name,
+          options_for_select(
+            translations_for_select,
+            ::I18n.locale
+          )
+        )
+      end
+
+      def render?
+        available_locales.many?
+      end
+
+      private
+
+      def available_locales
+        @_available_locales ||= Alchemy::I18n.available_locales.sort!
+      end
+
+      def translations_for_select
+        available_locales.map do |locale|
+          [Alchemy.t(locale, scope: :translations), locale]
+        end
+      end
+    end
+  end
+end

app/helpers/alchemy/admin/base_helper.rb

@@ -66,13 +66,6 @@ def link_to_dialog(content, url, options = {}, html_options = {})
         end
       end
 
-      # Used for translations selector in Alchemy cockpit user settings.
-      def translations_for_select
-        Alchemy::I18n.available_locales.sort.map do |locale|
-          [Alchemy.t(locale, scope: :translations), locale]
-        end
-      end
-
       def alchemy_admin_js_translations(locale = ::I18n.locale)
         render partial: "alchemy/admin/translations/#{locale}", formats: [:js]
       rescue ActionView::MissingTemplate

app/views/layouts/alchemy/admin.html.erb

@@ -83,10 +83,7 @@
         <% end %>
         <div id="user_info">
           <%= current_alchemy_user_name %>
-          <% if Alchemy::I18n.available_locales.length > 1 %>
-            <%= select_tag 'change_locale',
-              options_for_select(translations_for_select, ::I18n.locale) %>
-          <% end %>
+          <%= render Alchemy::Admin::LocaleSelect.new %>
         </div>
       </div>
       <div id="toolbar">

spec/components/alchemy/admin/locale_select_spec.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.describe Alchemy::Admin::LocaleSelect, type: :component do
+  subject! do
+    expect(Alchemy::I18n).to receive(:available_locales) { locales }
+    render
+  end
+
+  let(:render) { render_inline described_class.new }
+
+  context "with one available locale" do
+    let(:locales) { [:de] }
+
+    it "should not render anything" do
+      expect(rendered_content).to be_blank
+    end
+  end
+
+  context "with many available locales" do
+    let(:locales) { %i[de en] }
+
+    it "should return a select with available locales with current locale selected" do
+      expect(page).to have_selector("select[name='change_locale'] option[value='de'] + option[value='en'][selected]", text: "EN")
+    end
+
+    context "with name given" do
+      let(:render) { render_inline described_class.new(:language) }
+
+      it "should return a select with available locales with current locale selected" do
+        expect(page).to have_selector("select[name='language']")
+      end
+    end
+  end
+end

spec/helpers/alchemy/admin/base_helper_spec.rb

@@ -47,13 +47,6 @@ module Alchemy
       end
     end
 
-    describe "#translations_for_select" do
-      it "should return an Array of Arrays with available locales" do
-        allow(Alchemy::I18n).to receive(:available_locales).and_return(%i[de en cz it])
-        expect(helper.translations_for_select.size).to eq(4)
-      end
-    end
-
     describe "#clipboard_select_tag_options" do
       let(:page) { build_stubbed(:alchemy_page) }