Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving away from upgradeName-based control flows #10837

Open
mujahidkay opened this issue Jan 13, 2025 · 0 comments
Open

Moving away from upgradeName-based control flows #10837

mujahidkay opened this issue Jan 13, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mujahidkay
Copy link
Member

What is the Problem Being Solved?

Currently, for cases where we require different configurations based on different networks (devnet, emerynet, mainnet), we make use of specific upgrade names to trigger a specific control flow which maps to a specific configuration. This is the most recent example from upgrade 18. Ideally, in the best case scenario, we should only have one upgrade name and our core logic should determine which control flow to execute.

Description of the Design

The design of the problem is pretty simple. Instead of having network specific upgrade names, we should standardize it to a singular name. In case of multiple RCs during release, we would need new upgrade names for re applying the upgrades but that is mostly for internal testing and use. And even then, the control flow is not dependent on those upgrade names. The goal behind this is to minimize the confusion regarding upgrade names w.r.t external validators - as was observed multiple times during upgrade 18. Having a standardized agoric-upgrade-X each time moving forward will help in minimizing that confusion.

Security Considerations

None that I can think of.

Scaling Considerations

None

Test Plan

Kept as is. The only thing that will be different is how the specific flow is being triggered.

Upgrade Considerations

This is primarily for upgrades so this is all upgrade.

@mujahidkay mujahidkay added the enhancement New feature or request label Jan 13, 2025
@mujahidkay mujahidkay self-assigned this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant