feat(cosmic-swingset): make agd start stdout/stderr logs more consistent
#10821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-json-console-log
branch
from
ff30edd to
6c7761a
Compare
Deploying agoric-sdk with
|
| Latest commit: |
9af7269
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://71d3f333.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mfig-json-console-log.agoric-sdk.pages.dev |
michaelfig
force-pushed
the
mfig-json-console-log
branch
from
6c7761a to
9af7269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10820
Description
Standard output and error logs generated by the SwingSet VM when running
agd startshould be consistent with the Golang Zerolog output. The format should match the Golang logs controlled byagd start --log_format=plainor--log_format=json. Colouring the plain output with matching ANSI escapes is a non-goal.The
@agoric/telemetrypackage needed updating so that its components could be endowed with a properly-wrappedconsoleobject, such as that supplied by@agoric/cosmic-swingset/src/anylogger-agd.js.Security Considerations
Providing JSON-formatted stdout log output ensures that malicious vat code cannot confuse developers or operators with raw multiline console.log text.
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
Inspection of
agd startoutput, or consumption by a log ingestion service will demonstrate the functionality.Upgrade Considerations
n/a