Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-vaults proposal assumes an earlier governance parameter change #10793

Open
dckc opened this issue Jan 3, 2025 · 0 comments
Open

upgrade-vaults proposal assumes an earlier governance parameter change #10793

dckc opened this issue Jan 3, 2025 · 0 comments
Labels
bug Something isn't working contract-upgrade Governance Governance Vaults VaultFactor (née Treasury)

Comments

@dckc
Copy link
Member

dckc commented Jan 3, 2025

Describe the bug

The upgrade-vaults proposal assumes at least 1 vault factory governance parameter has previously been changed (i.e. that a notifier has issued a value). On devnet, it seems this was not the case as of the Oct 16/18 vaultFactory upgrades; this left an upgrade pending. The Dec 30 ReplaceAllElectorates coreEval changed the electorate parameter, which prompted the Oct 16/18 upgrade to complete; this left the vaultFactory connected to the Dec 16/18 governance contracts.

Timestamp Env Description Log query GC Log Hash
2024-10-16 devnet 73. Update PriceFeeds, Auction, and VaultFactory      
2024-10-18 devnet 75. Update PriceFeeds, Auction, and VaultFactory, take 2b      
2024-12-24   agoric-upgrade-18-rc6     f8c45b8
2024-12-30 devnet 78. SoftwareUpgrade Upgrade to agoric-upgrade-18-devnet      
2024-12-30 13:45:08 devnet agoric-upgrade-18 height applying upgrade "agoric-upgrade-18-devnet" at height: 6027800  
2024-12-30 13:55:34 devnet replaceAllElectorates coreProposal 2024-12-30T13:55:33.547Z SwingSet: vat: v1: coreProposal: replaceAllElectorates  
2024-12-30 14:04:19 devnet vaultFactory upgraded 2->3 upgraded 2024-12-30T14:04:18.509Z SwingSet: kernel: vat v47 upgraded from incarnation 2 to 3 with source b1-d6f6ad35cc5588342ae337bdc1599585c0f232cbc3e93f30d1626eadcb90ab9666480703949900b34efe31af38fac9479445cfd7776814819ccef6ad05bd78f8  
2024-12-30 14:04:33 devnet vaultFactory upgraded 3->4 upgraded 2024-12-30T14:04:33.371Z SwingSet: kernel: vat v47 upgraded from incarnation 3 to 4 with source b1-d6f6ad35cc5588342ae337bdc1599585c0f232cbc3e93f30d1626eadcb90ab9666480703949900b34efe31af38fac9479445cfd7776814819ccef6ad05bd78f8  
2024-12-30 14:14:58 devnet upgradeVaults coreProposal 2024-12-30T14:14:58.383Z SwingSet: vat: v1: coreProposal: upgradeVaults  

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Platform Environment

  • what OS are you using? what version of Node.js?
  • is there anything special/unusual about your platform?
  • what version of the Agoric-SDK are you using? (run git describe --tags --always)

Additional context

Screenshots

If applicable, add screenshots to help explain your problem, especially for UI interactions.

@dckc dckc added bug Something isn't working Governance Governance contract-upgrade Vaults VaultFactor (née Treasury) labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contract-upgrade Governance Governance Vaults VaultFactor (née Treasury)
Projects
None yet
Development

No branches or pull requests

1 participant