Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time-picker's icons are not displayed on events create page (Again 😞) #1354

Closed
diraulo opened this issue Oct 22, 2016 · 3 comments
Closed
Assignees

Comments

@diraulo
Copy link
Member

diraulo commented Oct 22, 2016

Steps to Reproduce (for bugs)

  1. Create new event
  2. Set a time for the event
  3. Note missing icons to increment/decrement

We've had this issue before see #755

@diraulo diraulo changed the title Time-picker's icons are not displayed on events create page Time-picker's icons are not displayed on events create page (Again 😞) Oct 22, 2016
@diraulo
Copy link
Member Author

diraulo commented Oct 25, 2016

screenshot 2016-10-25 16 41 33

@Maroo-b
Copy link
Contributor

Maroo-b commented Oct 30, 2016

I was checking this issue, it seems that's related to moving the app assets dependencies to npm.

According to the docs in http://jdewit.github.io/bootstrap-timepicker/ it's possible to change via custom configs, but it didn't work. I opened a new issue it the github repo: jdewit/bootstrap-timepicker#359

The previous fix in #755 was possible because we have access to the timepicker source code in vendor.

@tansaku tansaku added ready and removed estimated labels Nov 21, 2016
@c1505 c1505 self-assigned this Nov 22, 2016
@c1505
Copy link
Contributor

c1505 commented Nov 22, 2016

Updating to the most recent bootstrap-timepicker fixes this. I'll look to make sure it doesn't break anything else and submit a PR in the next day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants