Improve code quality and disable unnecessary warnings

Author: AgenttiX

Eject-Drive.ps1

@@ -2,12 +2,14 @@
 .SYNOPSIS
     Eject a disk such as a USB drive safely.
 .LINK
+    https://superuser.com/questions/1750399/eject-dismount-a-drive-using-powershell
     https://serverfault.com/a/580298
     https://community.spiceworks.com/topic/2120667-how-to-safely-remove-usb-key-in-windows-server-core?page=1#entry-7617376
-.PARAMETER Name
-    Drive letter
+.PARAMETER DriveLetter
+    Drive letter, e.g. C
 #>
 
+[Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingWMICmdlet", "Get-WmiObject", Justification="Used on purpose since the WMI object does not have the proper methods")]
 [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter", "DriveLetter", Justification="Set to null on purpose")]
 param(
     [Parameter(Mandatory=$true)][char]$DriveLetter
@@ -17,7 +19,9 @@ param(
 # $driveEject = New-Object -comObject Shell.Application
 # $driveEject.Namespace(17).ParseName("${DriveLetter}:").InvokeVerb("Eject")
 
-# Todo: replace WMI with CIM
+# WMI should be replaced with CIM
+# when a solution is found for calling the proper ejection methdods on the CIM object.
+# $vol = Get-CimInstance Win32_Volume | Where-Object {$_.Name -eq "${DriveLetter}:\"}
 $vol = Get-WmiObject -Class Win32_Volume | Where-Object {$_.Name -eq "${DriveLetter}:\"}
 $vol.DriveLetter = $null
 $vol.Put()

Install-Software.ps1

@@ -617,6 +617,7 @@ function CreateTable {
     .LINK
         https://docs.microsoft.com/en-us/dotnet/api/system.windows.forms.datagridview
     #>
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidAssignmentToAutomaticVariable", "sender", Justification="Probably used by library code")]
     [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter", "e", Justification="Probably used by library code")]
     [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter", "sender", Justification="Probably used by library code")]
     [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter", "Form", Justification="Reserved for future use")]

Report.ps1

@@ -7,6 +7,7 @@
     Only create the archive from existing reports. This is useful if you have generated additional reports after this script.
 #>
 
+[Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter", "Elevated", Justification="Used in utils")]
 param(
     [switch]$Elevated,
     [switch]$NoArchive

Setup-Syncthing.ps1

@@ -20,7 +20,7 @@ choco install syncthing -y
 $Domain = Get-ADDomain
 $AccountName = "svc-$("${env:ComputerName}".ToLower())-sync"
 $AccountFullName = "$($Domain.NetBIOSName)\${AccountName}"
-echo "Using account name: ${AccountName}"
+Show-Output "Using account name: ${AccountName}"
 
 try {
     # Get-LocalUser "Syncthing"

Utils.ps1

@@ -220,7 +220,7 @@ function Get-InstalledSoftware {
     #>
     [OutputType([System.Array])]
     param()
-    if ($script:InstalledSoftware -eq $null) {
+    if ($null -eq $script:InstalledSoftware) {
         Show-Information "Getting the list of installed software. This may take a while."
         $script:InstalledSoftware = Get-CimInstance -ClassName Win32_Product
     }
@@ -336,6 +336,7 @@ function Install-Executable {
 }
 
 function Install-FromUri {
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingBrokenHashAlgorithms", "", Justification="Legacy MD5 support is on purpose for backwards compatibility")]
     [OutputType([int])]
     param(
         [Parameter(mandatory=$true)][string]$Name,