Skip to content
This repository was archived by the owner on May 11, 2026. It is now read-only.

Commit 41dfca5

Browse files
committed
fix(ci): unblock validate.yml — quarantine broken .advanced.yaml + fix swarm/voice paths
The salvaged validate.yml workflow had three issues that broke its "Schema compliance" job in the most recent CI run: 1. .grok/grok-{agent,security,workflow}.advanced.yaml fail validation against the canonical schemas (additionalProperties: false rejects `model_override` / `safety_profile`; tool names like recall_memory, summarize_changes, fetch_url, search_x, save_memory aren't in the schema enum). These files came from the polish-yKpCT branch and targeted an older schema generation; salvage preserved them as reference but they don't conform to v1.3.0 schemas. Fix: move them under .grok/proposed/ (mirrors the schemas/proposed/ pattern established when the Draft 2020-12 schemas were relocated). Drop the .advanced.yaml lines from validate.yml. The files are preserved on disk; promoting them to the canonical surface later requires either fixing the content or extending the schemas. 2. validate.yml referenced schemas/grok-{swarm,voice}.schema.json, but those Draft 2020-12 files were relocated to schemas/proposed/ in commit 8e4f441 to keep the schema-smoke check in validate-schemas.yml green. Fix: update the two paths to schemas/proposed/... 3. The swarm/voice steps now make their role explicit — they cover the polish-branch (Draft 2020-12) design at specs/grok-{swarm, voice}.yaml. The audit-ecosystem-state design at .grok/grok-swarm.yaml + schemas/grok-swarm.json (Draft 7) is already covered by the canonical validate-schemas.yml workflow. Reproduced locally with: pip install "check-jsonschema>=0.28" check-jsonschema --schemafile schemas/grok-agent.json \ .grok/grok-agent.advanced.yaml # FAIL before this commit Verified after fix: - all 14 schema-validate steps in validate.yml: PASS - validate-schemas.yml (yamllint + ajv-cli + schema-smoke): green - 31/31 ajv-cli matrix entries: PASS https://claude.ai/code/session_019yLiz83EHCnYXCZkEK9c9i
1 parent 1dbe30a commit 41dfca5

4 files changed

Lines changed: 15 additions & 13 deletions

File tree

.github/workflows/validate.yml

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -81,23 +81,20 @@ jobs:
8181
- name: Install check-jsonschema
8282
run: pip install "check-jsonschema>=0.28"
8383

84-
- name: Validate grok-agent specs
84+
- name: Validate grok-agent spec
8585
run: |
8686
check-jsonschema --schemafile schemas/grok-agent.json \
87-
.grok/grok-agent.yaml \
88-
.grok/grok-agent.advanced.yaml
87+
.grok/grok-agent.yaml
8988
90-
- name: Validate grok-workflow specs
89+
- name: Validate grok-workflow spec
9190
run: |
9291
check-jsonschema --schemafile schemas/grok-workflow.json \
93-
.grok/grok-workflow.yaml \
94-
.grok/grok-workflow.advanced.yaml
92+
.grok/grok-workflow.yaml
9593
96-
- name: Validate grok-security specs
94+
- name: Validate grok-security spec
9795
run: |
9896
check-jsonschema --schemafile schemas/grok-security.json \
99-
.grok/grok-security.yaml \
100-
.grok/grok-security.advanced.yaml
97+
.grok/grok-security.yaml
10198
10299
- name: Validate grok-config
103100
run: check-jsonschema --schemafile schemas/grok-config.json .grok/grok-config.yaml
@@ -126,8 +123,13 @@ jobs:
126123
- name: Validate grok-ui
127124
run: check-jsonschema --schemafile schemas/grok-ui.json .grok/grok-ui.yaml
128125

129-
- name: Validate grok-swarm spec
130-
run: check-jsonschema --schemafile schemas/grok-swarm.schema.json specs/grok-swarm.yaml
126+
# Proposed (Draft 2020-12) schemas live under schemas/proposed/ and
127+
# validate the specs/ entries from the polish-branch design. The
128+
# canonical grok-swarm/grok-voice work (audit-ecosystem-state branch
129+
# variant) is at .grok/grok-swarm.yaml + schemas/grok-swarm.json and
130+
# is already covered by validate-schemas.yml.
131+
- name: Validate proposed grok-swarm spec
132+
run: check-jsonschema --schemafile schemas/proposed/grok-swarm.schema.json specs/grok-swarm.yaml
131133

132-
- name: Validate grok-voice spec
133-
run: check-jsonschema --schemafile schemas/grok-voice.schema.json specs/grok-voice.yaml
134+
- name: Validate proposed grok-voice spec
135+
run: check-jsonschema --schemafile schemas/proposed/grok-voice.schema.json specs/grok-voice.yaml
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)